linux-kernel - Re: [PATCH v3 09/13] i2c: nvidia-gpu: Remove ccgx,firmware-build property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 15 Nov 2022 12:19:12 +0000
From:   Jon Hunter <jonathanh@...dia.com>
To:     Wayne Chang <waynec@...dia.com>, gregkh@...uxfoundation.org,
        robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org,
        treding@...dia.com, thierry.reding@...il.com,
        heikki.krogerus@...ux.intel.com, ajayg@...dia.com,
        vkoul@...nel.org, p.zabel@...gutronix.de, balbi@...nel.org,
        mathias.nyman@...el.com, jckuo@...dia.com
Cc:     linux-usb@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, singhanc@...dia.com,
        linux-i2c@...r.kernel.org, linux-phy@...ts.infradead.org,
        linux-tegra@...r.kernel.org
Subject: Re: [PATCH v3 09/13] i2c: nvidia-gpu: Remove ccgx,firmware-build
 property



On 14/11/2022 12:40, Wayne Chang wrote:
> Remove the property ccgx,firmware-build as we have added well-known
> regex cypress,firmware-build.
> 
> Signed-off-by: Wayne Chang <waynec@...dia.com>
> ---
> V2 -> V3:nothing has changed
> V1 -> V2:New added for bisectablility
>   drivers/i2c/busses/i2c-nvidia-gpu.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/i2c/busses/i2c-nvidia-gpu.c b/drivers/i2c/busses/i2c-nvidia-gpu.c
> index 9b2e13bd44db..092d4d52098c 100644
> --- a/drivers/i2c/busses/i2c-nvidia-gpu.c
> +++ b/drivers/i2c/busses/i2c-nvidia-gpu.c
> @@ -259,8 +259,7 @@ static const struct pci_device_id gpu_i2c_ids[] = {
>   MODULE_DEVICE_TABLE(pci, gpu_i2c_ids);
>   
>   static const struct property_entry ccgx_props[] = {
> -	/* Use FW built for NVIDIA (nv) only */
> -	PROPERTY_ENTRY_U16("ccgx,firmware-build", ('n' << 8) | 'v'),
> +	/* Use FW built for NVIDIA GPU only */
>   	PROPERTY_ENTRY_STRING("cypress,firmware-build", "nvidia,gpu"),
>   	{ }
>   };


Reviewed-by: Jon Hunter <jonathanh@...dia.com>

Thanks
Jon

-- 
nvpublic