linux-kernel - Re: [PATCH v2 1/2] dt-bindings: soc: qcom: Add bindings for Qualcomm Ramp Controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <342d556a-e710-590c-3c81-fcc60bbaa6e7@linaro.org>
Date:   Tue, 15 Nov 2022 14:36:40 +0100
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...labora.com>,
        Rob Herring <robh@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>
Cc:     marijn.suijten@...ainline.org, konrad.dybcio@...ainline.org,
        kernel@...labora.com, andersson@...nel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-msm@...r.kernel.org, robh+dt@...nel.org,
        agross@...nel.org
Subject: Re: [PATCH v2 1/2] dt-bindings: soc: qcom: Add bindings for Qualcomm
 Ramp Controller

On 11/11/2022 11:05, AngeloGioacchino Del Regno wrote:
> Il 04/11/22 18:54, Rob Herring ha scritto:
>>
>> On Fri, 04 Nov 2022 15:22:03 +0100, AngeloGioacchino Del Regno wrote:
>>> Document bindings for the Qualcomm Ramp Controller, found on various
>>> legacy Qualcomm SoCs.
>>>
>>> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
>>> ---
>>>   .../qcom/qcom,msm8976-ramp-controller.yaml    | 37 +++++++++++++++++++
>>>   1 file changed, 37 insertions(+)
>>>   create mode 100644 Documentation/devicetree/bindings/soc/qcom/qcom,msm8976-ramp-controller.yaml
>>>
>>
>> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
>> on your patch (DT_CHECKER_FLAGS is new in v5.13):
>>
>> yamllint warnings/errors:
>>
>> dtschema/dtc warnings/errors:
>> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/soc/qcom/qcom,msm8976-ramp-controller.example.dtb: power-controller@...4000: '#power-domain-cells' is a required property
>> 	From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/power/power-domain.yaml
>>
>> doc reference errors (make refcheckdocs):
>>
>> See https://patchwork.ozlabs.org/patch/
>>
>> This check can fail if there are any dependencies. The base for a patch
>> series is generally the most recent rc1.
>>
>> If you already ran 'make dt_binding_check' and didn't see the above
>> error(s), then make sure 'yamllint' is installed and dt-schema is up to
>> date:
>>
>> pip3 install dtschema --upgrade
>>
>> Please check and re-submit.
>>
> 
> I'm unsure about what I should do about this one.
> This is a power-controller, but does *not* need any #power-domain-cells, as it is
> standalone and doesn't require being attached to anything.

power-domain-cells are for power domain providers, not consumers. The
generic binding expect that nodes called power-controller are exactly
like that.

Solutions could be:
1. Rename the node to something else. I cannot deduct the type of the
device based on description. What is "sequence ID" and how is it even
closely related to power control?

2. Narrow the node name in power-domain.yaml which would require changes
in multiple DTS and bindings.

3. Do not require power-domain-cells for power-controllers, only for
power-domains.

Best regards,
Krzysztof