linux-kernel - Re: [PATCH v3] tcp: Add listening address to SYN flood message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20221114180219.0a9900f4@hermes.local>
Date:   Mon, 14 Nov 2022 18:02:19 -0800
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Eric Dumazet <edumazet@...gle.com>
Cc:     Jamie Bainbridge <jamie.bainbridge@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>,
        David Ahern <dsahern@...nel.org>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] tcp: Add listening address to SYN flood message

On Mon, 14 Nov 2022 09:31:38 -0800
Eric Dumazet <edumazet@...gle.com> wrote:

> On Sun, Nov 13, 2022 at 5:00 PM Jamie Bainbridge
> <jamie.bainbridge@...il.com> wrote:
> >
> > The SYN flood message prints the listening port number, but with many
> > processes bound to the same port on different IPs, it's impossible to
> > tell which socket is the problem.
> >
> > Add the listen IP address to the SYN flood message.
> >
> > For IPv6 use "[IP]:port" as per RFC-5952 and to provide ease of
> > copy-paste to "ss" filters. For IPv4 use "IP:port" to match.
> >
> > Each protcol's "any" address and a host address now look like:
> >
> >  Possible SYN flooding on port 0.0.0.0:9001.
> >  Possible SYN flooding on port 127.0.0.1:9001.
> >  Possible SYN flooding on port [::]:9001.
> >  Possible SYN flooding on port [fc00::1]:9001.
> >
> > Signed-off-by: Jamie Bainbridge <jamie.bainbridge@...il.com>
> > ---  
> 
> Reviewed-by: Eric Dumazet <edumazet@...gle.com>

Thanks for cleaning this up.
Reviewed-by: Stephen Hemminger <stephen@...workplumber.org>