linux-kernel - Re: [PATCH 5.15 000/131] 5.15.79-rc1 review

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y3ObPwyWx4bEAoAt@kroah.com>
Date:   Tue, 15 Nov 2022 14:59:27 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     shaozhengchao <shaozhengchao@...wei.com>
Cc:     Naresh Kamboju <naresh.kamboju@...aro.org>, stable@...r.kernel.org,
        patches@...ts.linux.dev, linux-kernel@...r.kernel.org,
        torvalds@...ux-foundation.org, akpm@...ux-foundation.org,
        linux@...ck-us.net, shuah@...nel.org, patches@...nelci.org,
        lkft-triage@...ts.linaro.org, pavel@...x.de, jonathanh@...dia.com,
        f.fainelli@...il.com, sudipm.mukherjee@...il.com,
        srw@...dewatkins.net, rwarsow@....de,
        Leon Romanovsky <leonro@...dia.com>,
        Paolo Abeni <pabeni@...hat.com>,
        Sasha Levin <sashal@...nel.org>
Subject: Re: [PATCH 5.15 000/131] 5.15.79-rc1 review

On Tue, Nov 15, 2022 at 11:34:12AM +0800, shaozhengchao wrote:
> 
> 
> On 2022/11/15 10:56, Naresh Kamboju wrote:
> > On Mon, 14 Nov 2022 at 18:24, Greg Kroah-Hartman
> > <gregkh@...uxfoundation.org> wrote:
> > > 
> > > This is the start of the stable review cycle for the 5.15.79 release.
> > > There are 131 patches in this series, all will be posted as a response
> > > to this one.  If anyone has any issues with these being applied, please
> > > let me know.
> > > 
> > > Responses should be made by Wed, 16 Nov 2022 12:44:21 +0000.
> > > Anything received after that time might be too late.
> > > 
> > > The whole patch series can be found in one patch at:
> > >          https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.15.79-rc1.gz
> > > or in the git tree and branch at:
> > >          git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.15.y
> > > and the diffstat can be found below.
> > > 
> > > thanks,
> > > 
> > > greg k-h
> > 
> > As others reported,
> > arm: allmodconfig  failed [1] due to following warnings / errors.
> > 
> > drivers/net/ethernet/mediatek/mtk_star_emac.c: In function 'mtk_star_enable':
> > drivers/net/ethernet/mediatek/mtk_star_emac.c:980:22: error: 'struct
> > mtk_star_priv' has no member named 'rx_napi'; did you mean 'napi'?
> >    980 |  napi_disable(&priv->rx_napi);
> >        |                      ^~~~~~~
> >        |                      napi
> > drivers/net/ethernet/mediatek/mtk_star_emac.c:981:22: error: 'struct
> > mtk_star_priv' has no member named 'tx_napi'; did you mean 'napi'?
> >    981 |  napi_disable(&priv->tx_napi);
> >        |                      ^~~~~~~
> >        |                      napi
> > 
> > 
> > ---
> > net: ethernet: mtk-star-emac: disable napi when connect and start PHY
> > failed in mtk_star_enable()
> > [ Upstream commit b0c09c7f08c2467b2089bdf4adb2fbbc2464f4a8 ]
> > 
> > 
> > [1] https://builds.tuxbuild.com/2HXmwUDUvmWI1Uc7zsdXNcsTqW1/
> > 
> > --
> > Linaro LKFT
> > https://lkft.linaro.org
> 
> Yes ,For stable-5.10, commit 0a8bd81fd6aaace14979152e0540da8ff158a00a
> ("net: ethernet: mtk-star-emac: separate tx/rx handling with two NAPIs")
> is not merged. So, please use napi_disable(&priv->napi) instead of
> napi_disable(&priv->rx_napi) and napi_disable(&priv->tx_napi).

I think you mean 5.15 here, not 5.10, right?

Can you send a properly backported version of this commit for 5.10.y and
5.15.y so that I can queue it up?  I'll go drop this offending one from
the queue now and push out a -rc2 so that it doesn't stall the release.

thanks,

greg k-h