lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <Y3OaLlcTJECIeZoB@yilunxu-OptiPlex-7050>
Date:   Tue, 15 Nov 2022 21:54:54 +0800
From:   Xu Yilun <yilun.xu@...el.com>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     Russ Weight <russell.h.weight@...el.com>, mdf@...nel.org,
        hao.wu@...el.com, trix@...hat.com, linux-fpga@...r.kernel.org,
        linux-kernel@...r.kernel.org, lgoncalv@...hat.com,
        marpagan@...hat.com, matthew.gerlach@...ux.intel.com,
        basheer.ahmed.muddebihal@...el.com, tianfei.zhang@...el.com,
        kernel test robot <lkp@...el.com>, stable@...r.kernel.org
Subject: Re: [PATCH v1 1/1] fpga: m10bmc-sec: Fix kconfig dependencies

On 2022-11-14 at 17:03:03 -0800, Randy Dunlap wrote:
> 
> 
> On 11/14/22 16:11, Russ Weight wrote:
> > The secure update driver depends on the firmware-upload functionality of
> > the firmware-loader. The firmware-loader is carried in the firmware-class
> > driver which is enabled with the tristate CONFIG_FW_LOADER option. The
> > firmware-upload functionality is included in the firmware-class driver if
> > the bool FW_UPLOAD config is set.
> > 
> > The current dependency statement, "depends on FW_UPLOAD", is not adequate
> > because it does not implicitly turn on FW_LOADER. Instead of adding a
> > dependency, follow the convention used by drivers that require the
> > FW_LOADER_USER_HELPER functionality of the firmware-loader by using
> > select for both FW_LOADER and FW_UPLOAD.
> > 
> > Fixes: bdf86d0e6ca3 ("fpga: m10bmc-sec: create max10 bmc secure update")
> > Reported-by: kernel test robot <lkp@...el.com>
> > Cc: stable@...r.kernel.org
> > Signed-off-by: Russ Weight <russell.h.weight@...el.com>
> 
> Acked-by: Randy Dunlap <rdunlap@...radead.org> # build-tested

Acked-by: Xu Yilun <yilun.xu@...el.com>

Applied to for-6.1

> 
> Thanks.
> 
> > ---
> >  drivers/fpga/Kconfig | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> > 
> > diff --git a/drivers/fpga/Kconfig b/drivers/fpga/Kconfig
> > index d1a8107fdcb3..6ce143dafd04 100644
> > --- a/drivers/fpga/Kconfig
> > +++ b/drivers/fpga/Kconfig
> > @@ -246,7 +246,9 @@ config FPGA_MGR_VERSAL_FPGA
> >  
> >  config FPGA_M10_BMC_SEC_UPDATE
> >  	tristate "Intel MAX10 BMC Secure Update driver"
> > -	depends on MFD_INTEL_M10_BMC && FW_UPLOAD
> > +	depends on MFD_INTEL_M10_BMC
> > +	select FW_LOADER
> > +	select FW_UPLOAD
> >  	help
> >  	  Secure update support for the Intel MAX10 board management
> >  	  controller.
> 
> -- 
> ~Randy

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ