linux-kernel - RE: [PATCH v3 0/1] aacraid: Host adapter Adaptec 6405 constantly resets under high io load

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BYAPR11MB36065EE0321C0AE6A4A3ECC7FA049@BYAPR11MB3606.namprd11.prod.outlook.com>
Date:   Tue, 15 Nov 2022 14:05:35 +0000
From:   <Sagar.Biradar@...rochip.com>
To:     <james.hilliard1@...il.com>
CC:     <martin.petersen@...cle.com>, <khorenko@...tuozzo.com>,
        <christian@...ssegger.com>, <aacraid@...rosemi.com>,
        <Don.Brace@...rochip.com>, <Tom.White@...rochip.com>,
        <linux-scsi@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v3 0/1] aacraid: Host adapter Adaptec 6405 constantly
 resets under high io load

Hi James,
I have looked into the patch thoroughly.
We suspect this change might expose an old legacy interrupt issue on some processors.

We are currently debugging and digging further details to be able to explain it in much detailed fashion.
I will keep you the thread posted as soon as we have something interesting.

Sagar

-----Original Message-----
From: James Hilliard <james.hilliard1@...il.com> 
Sent: Monday, November 14, 2022 12:13 AM
To: Sagar Biradar - C34249 <Sagar.Biradar@...rochip.com>
Cc: martin.petersen@...cle.com; khorenko@...tuozzo.com; christian@...ssegger.com; aacraid@...rosemi.com; Don Brace - C33706 <Don.Brace@...rochip.com>; Tom White - C33503 <Tom.White@...rochip.com>; linux-scsi@...r.kernel.org; Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 0/1] aacraid: Host adapter Adaptec 6405 constantly resets under high io load

EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe

On Thu, Oct 27, 2022 at 1:17 PM <Sagar.Biradar@...rochip.com> wrote:
>
> Hi James and Konstantin,
>
> *Limiting the audience to avoid spamming*
>
> Sorry for delayed response as I was on vacation.
> This one got missed somehow as someone else was looking into this and is no longer with the company.
>
> I will look into this, meanwhile I wanted to check if you (or someone else you know) had a chance to test this thoroughly with the latest kernel?
> I will get back to you with some more questions or the confirmation in a day or two max.

Did this ever get looked at?

As this exact patch was merged into the vendor aacraid a while ago I'm not sure why it wouldn't be good to merge to mainline as well.

Vendor aacraid release with this patch merged:
https://download.adaptec.com/raid/aac/linux/aacraid-linux-src-1.2.1-60001.tgz

>
>
> Thanks for your patience.
> Sagar
>
>
> -----Original Message-----
> From: James Hilliard <james.hilliard1@...il.com>
> Sent: Thursday, October 27, 2022 1:40 AM
> To: Martin K. Petersen <martin.petersen@...cle.com>
> Cc: Konstantin Khorenko <khorenko@...tuozzo.com>; Christian Großegger 
> <christian@...ssegger.com>; linux-scsi@...r.kernel.org; Adaptec OEM 
> Raid Solutions <aacraid@...rosemi.com>; Sagar Biradar - C34249 
> <Sagar.Biradar@...rochip.com>; Linux Kernel Mailing List 
> <linux-kernel@...r.kernel.org>; Don Brace - C33706 
> <Don.Brace@...rochip.com>
> Subject: Re: [PATCH v3 0/1] aacraid: Host adapter Adaptec 6405 
> constantly resets under high io load
>
> EXTERNAL EMAIL: Do not click links or open attachments unless you know 
> the content is safe
>
> On Wed, Oct 19, 2022 at 2:03 PM Konstantin Khorenko <khorenko@...tuozzo.com> wrote:
> >
> > On 10.10.2022 14:31, James Hilliard wrote:
> > > On Tue, Feb 22, 2022 at 10:41 PM Martin K. Petersen 
> > > <martin.petersen@...cle.com> wrote:
> > >>
> > >>
> > >> Christian,
> > >>
> > >>> The faulty patch (Commit: 395e5df79a9588abf) from 2017 should be 
> > >>> repaired with Konstantin Khorenko (1):
> > >>>
> > >>>    scsi: aacraid: resurrect correct arc ctrl checks for Series-6
> > >>
> > >> It would be great to get this patch resubmitted by Konstantin and 
> > >> acked by Microchip.
>
> Can we merge this as is since microchip does not appear to be maintaining this driver any more or responding?
>
> > >
> > > Does the patch need to be rebased?
> >
> > James, i have just checked - the old patch (v3) applies cleanly onto latest master branch.
> >
> > > Based on this it looks like someone at microchip may have already reviewed:
> > > v3 changes:
> > >   * introduced another wrapper to check for devices except for Series 6
> > >     controllers upon request from Sagar Biradar (Microchip)
> >
> > Well, back in the year 2019 i've created a bug in RedHat bugzilla
> > https://bugzilla.redhat.com/show_bug.cgi?id=1724077
> > (the bug is private, this is default for Redhat bugs)
> >
> > In this bug Sagar Biradar (with the email @microchip.com) suggested 
> > me to rework the patch - i've done that and sent the v3.
> >
> > And nothing happened after that, but in a ~year (2020-06-19) the bug 
> > was closed with the resolution NOTABUG and a comment that S6 users will find the patch useful.
> >
> > i suppose S6 is so old that RedHat just does not have customers 
> > using it and Microchip company itself is also not that interested in handling so old hardware issues.
> >
> > Sorry, i was unable to get a final ack from Microchip, i've written 
> > direct emails to the addresses which is found in the internet, tried 
> > to connect via linkedin, no luck.
> >
> > --
> > Konstantin Khorenko