[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20221115092638.62cb7322@gandalf.local.home>
Date: Tue, 15 Nov 2022 09:26:38 -0500
From: Steven Rostedt <rostedt@...dmis.org>
To: Chuck Lever <chuck.lever@...cle.com>
Cc: linux-nfs@...r.kernel.org, linux-rdma@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] trace: Relocate event helper files
On Mon, 14 Nov 2022 10:16:12 -0500
Chuck Lever <chuck.lever@...cle.com> wrote:
> Steven Rostedt says:
> > The include/trace/events/ directory should only hold files that
> > are to create events, not headers that hold helper functions.
> >
> > Can you please move them out of include/trace/events/ as that
> > directory is "special" in the creation of events.
>
> Signed-off-by: Chuck Lever <chuck.lever@...cle.com>
> ---
> drivers/infiniband/core/cm_trace.h | 2
> drivers/infiniband/core/cma_trace.h | 2
> fs/nfs/nfs4trace.h | 6 -
> fs/nfs/nfstrace.h | 6 -
> include/trace/events/fs.h | 122 -----------
> include/trace/events/nfs.h | 375 -----------------------------------
> include/trace/events/rdma.h | 168 ----------------
> include/trace/events/rpcgss.h | 2
> include/trace/events/rpcrdma.h | 4
> include/trace/events/sunrpc.h | 2
> include/trace/events/sunrpc_base.h | 18 --
> include/trace/misc/fs.h | 122 +++++++++++
> include/trace/misc/nfs.h | 375 +++++++++++++++++++++++++++++++++++
> include/trace/misc/rdma.h | 168 ++++++++++++++++
> include/trace/misc/sunrpc.h | 18 ++
> 15 files changed, 695 insertions(+), 695 deletions(-)
> delete mode 100644 include/trace/events/fs.h
> delete mode 100644 include/trace/events/nfs.h
> delete mode 100644 include/trace/events/rdma.h
> delete mode 100644 include/trace/events/sunrpc_base.h
> create mode 100644 include/trace/misc/fs.h
> create mode 100644 include/trace/misc/nfs.h
> create mode 100644 include/trace/misc/rdma.h
> create mode 100644 include/trace/misc/sunrpc.h
>
> Note: with an Acked-by from both the NFS client and RDMA core
> maintainers I can take this through the nfsd for-next tree, unless
> someone has another suggestion.
Acked-by: Steven Rostedt (Google) <rostedt@...dmis.org>
-- Steve
Powered by blists - more mailing lists