linux-kernel - Re: [PATCH v2] dt-bindings: spi: convert Freescale DSPI to dt-schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20221115143152.xjfr7v333rhjhd3m@skbuf>
Date:   Tue, 15 Nov 2022 14:31:53 +0000
From:   Vladimir Oltean <vladimir.oltean@....com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
CC:     "linux-spi@...r.kernel.org" <linux-spi@...r.kernel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Vladimir Oltean <olteanv@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Kuldeep Singh <singh.kuldeep87k@...il.com>,
        Michael Walle <michael@...le.cc>,
        Kuldeep Singh <kuldeep.singh@....com>
Subject: Re: [PATCH v2] dt-bindings: spi: convert Freescale DSPI to dt-schema

On Tue, Nov 15, 2022 at 03:26:11PM +0100, Krzysztof Kozlowski wrote:
> To be clear: ls1012a, ls1028a and lx2160a should be either followed by
> compatible or not. Cannot be both.

LS1012A should be followed by fallback compatible for practical reasons
(Linux kernel worked that way up to 5.7, time during which LS1012A was
supported).

LS1028A and LX2160A device trees were both introduced after the Linux
kernel started looking at specific device trees, so I believe that Linux
never relied on the fallback compatible string and it could be removed.
The fallback is present in device trees in circulation, even if the .txt
schema says it isn't required. I don't know what the BSDs do about this,
so I'd be tempted to leave them in the camp with required fallbacks,
just because it's not worth risking a regression.