[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAMRc=MeE97YAzow7MX5380_ucLdUONYqMd3+Nvd6YW_h9oHPJQ@mail.gmail.com>
Date: Tue, 15 Nov 2022 15:42:09 +0100
From: Bartosz Golaszewski <brgl@...ev.pl>
To: Aidan MacDonald <aidanmacdonald.0x0@...il.com>
Cc: michael@...le.cc, linus.walleij@...aro.org,
linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] gpio: sl28cpld: Replace irqchip mask_invert with unmask_base
On Sat, Nov 12, 2022 at 4:29 PM Aidan MacDonald
<aidanmacdonald.0x0@...il.com> wrote:
>
> Remove use of the deprecated mask_invert flag. Inverted mask
> registers (where a '1' bit enables an IRQ) can be described more
> directly as an unmask register.
>
> Signed-off-by: Aidan MacDonald <aidanmacdonald.0x0@...il.com>
> ---
> drivers/gpio/gpio-sl28cpld.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpio/gpio-sl28cpld.c b/drivers/gpio/gpio-sl28cpld.c
> index 52404736ac86..2195f88c2048 100644
> --- a/drivers/gpio/gpio-sl28cpld.c
> +++ b/drivers/gpio/gpio-sl28cpld.c
> @@ -70,8 +70,7 @@ static int sl28cpld_gpio_irq_init(struct platform_device *pdev,
> irq_chip->num_irqs = ARRAY_SIZE(sl28cpld_gpio_irqs);
> irq_chip->num_regs = 1;
> irq_chip->status_base = base + GPIO_REG_IP;
> - irq_chip->mask_base = base + GPIO_REG_IE;
> - irq_chip->mask_invert = true;
> + irq_chip->unmask_base = base + GPIO_REG_IE;
> irq_chip->ack_base = base + GPIO_REG_IP;
>
> ret = devm_regmap_add_irq_chip_fwnode(dev, dev_fwnode(dev),
> --
> 2.38.1
>
Applied, thanks!
Bartosz
Powered by blists - more mailing lists