linux-kernel - Re: [PATCH] PCI: vmd: Clean up some inconsistent indenting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Y3RdR+9QSVPWyae3@rocinante>
Date:   Wed, 16 Nov 2022 12:47:19 +0900
From:   Krzysztof Wilczyński <kw@...ux.com>
To:     Christoph Hellwig <hch@...radead.org>
Cc:     Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>,
        nirmal.patel@...ux.intel.com, jonathan.derrick@...ux.dev,
        lpieralisi@...nel.org, robh@...nel.org, bhelgaas@...gle.com,
        linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org,
        Abaci Robot <abaci@...ux.alibaba.com>
Subject: Re: [PATCH] PCI: vmd: Clean up some inconsistent indenting

Hello,

> > +	if (vmd->irq_domain)
> > +		vmd_set_msi_remapping(vmd, true);
> > +	else
> > +		vmd_set_msi_remapping(vmd, false);
> 
> Why not go one step further:
> 
> 	vmd_set_msi_remapping(vmd, !!vmd->irq_domain);

Jiapeng, if you want to get this patch merged, and it's a nice clean-up,
then apply suggestion from Christoph and send a v2, if possible.

	Krzysztof