linux-kernel - Re: [PATCH v8 1/6] dt-bindings: remoteproc: Add PRU consumer bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20221116180949.GC61935@p14s>
Date:   Wed, 16 Nov 2022 11:09:49 -0700
From:   Mathieu Poirier <mathieu.poirier@...aro.org>
To:     Rob Herring <robh@...nel.org>
Cc:     MD Danish Anwar <danishanwar@...com>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Suman Anna <s-anna@...com>, Roger Quadros <rogerq@...nel.org>,
        "Andrew F . Davis" <afd@...com>, nm@...com, vigneshr@...com,
        srk@...com, linux-remoteproc@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v8 1/6] dt-bindings: remoteproc: Add PRU consumer bindings

On Wed, Nov 16, 2022 at 10:09:48AM -0600, Rob Herring wrote:
> On Wed, Nov 16, 2022 at 05:46:29PM +0530, MD Danish Anwar wrote:
> > From: Suman Anna <s-anna@...com>
> > 
> > Add DT schema binding for PRU consumers. The binding includes
> > all the common properties that can be used by different PRU consumer
> > or application nodes and supported by the PRU remoteproc driver.
> > These are used to configure the PRU hardware for specific user
> > applications.
> > 
> > The application nodes themselves should define their own bindings.
> > 
> > Co-developed-by: Tero Kristo <t-kristo@...com>
> > Co-developed-by: Suman Anna <s-anna@...com>
> > Co-developed-by: Grzegorz Jaszczyk <grzegorz.jaszczyk@...aro.org>
> > Co-developed-by: Puranjay Mohan <p-mohan@...com>
> > Signed-off-by: MD Danish Anwar <danishanwar@...com>
> 
> Run checkpatch.pl and fix the warnings with the tags.

My bad - I asked Danish to remove the SoBs to lighten the changelog
presentation.  Danish, do you absolutely need to list everyone that touched that
patchset?  If so I suppose just listing the SoBs would be a compromise.

> 
> You didn't add review/ack tags either.

Those are important.  

Please send another patchset that clears checkpatch with review/acks and I'll
look at it.

Thanks,
Mathieu

> 
> > ---
> >  .../bindings/remoteproc/ti,pru-consumer.yaml  | 60 +++++++++++++++++++
> >  1 file changed, 60 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/remoteproc/ti,pru-consumer.yaml