linux-kernel - Re: [PATCH v7 4/6] mfd: tps65219: Add driver for TI TPS65219 PMIC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y3Un36o/lACru9Kq@google.com>
Date:   Wed, 16 Nov 2022 18:11:43 +0000
From:   Lee Jones <lee@...nel.org>
To:     Jerome Neanne <jneanne@...libre.com>
Cc:     lgirdwood@...il.com, broonie@...nel.org, robh+dt@...nel.org,
        nm@...com, kristo@...nel.org, dmitry.torokhov@...il.com,
        krzysztof.kozlowski+dt@...aro.org, catalin.marinas@....com,
        will@...nel.org, tony@...mide.com, vigneshr@...com,
        shawnguo@...nel.org, geert+renesas@...der.be,
        dmitry.baryshkov@...aro.org, marcel.ziswiler@...adex.com,
        vkoul@...nel.org, biju.das.jz@...renesas.com, arnd@...db.de,
        jeff@...undy.com, afd@...com, khilman@...libre.com,
        narmstrong@...libre.com, msp@...libre.com, j-keerthy@...com,
        linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-input@...r.kernel.org,
        linux-omap@...r.kernel.org
Subject: Re: [PATCH v7 4/6] mfd: tps65219: Add driver for TI TPS65219 PMIC

On Fri, 04 Nov 2022, Jerome Neanne wrote:

> The TPS65219 is a power management IC PMIC designed to supply a wide
> range of SoCs in both portable and stationary applications. Any SoC can
> control TPS65219 over a standard I2C interface.
> 
> It contains the following components:
> - Regulators.
> - Over Temperature warning and Shut down.
> - GPIOs
> - Multi Function Pins (MFP)
> - power-button
> 
> This patch adds support for tps65219 PMIC. At this time only
> the functionalities listed below are made available:
> 
> - Regulators probe and functionalities
> - warm and cold reset support
> - SW shutdown support
> - Regulator warnings via IRQs
> - Power-button via IRQ
> 
> Signed-off-by: Jerome Neanne <jneanne@...libre.com>
> Signed-off-by: Markus Schneider-Pargmann <msp@...libre.com>
> Acked-for-mfd-by: Lee Jones <lee@...nel.org>
> ---
> 
> Notes:
>     Changes in v7:
>     Lee Jones review
>     - Kconfig nit: button that is
>     - tps65219.c, nits: '\n' x2
>     - tps65219.c, nit: { .name = "tps65219-gpios", },
>     - tps65219.h, nit: Power Management IC
>     - tps65219.h, rework header: struct tps65219
>     - tps65219.h, remove Superflous " " /* MFD_TPS65219_H */
>     - remove unused tps65219_soft_shutdown further to make W=1 check
>     Biju Das review:
>     - Remove all includes that are not mandatory
>     - Remove container_of err check
> 
>  MAINTAINERS                  |   1 +
>  drivers/mfd/Kconfig          |  14 ++
>  drivers/mfd/Makefile         |   1 +
>  drivers/mfd/tps65219.c       | 299 ++++++++++++++++++++++++++++++
>  include/linux/mfd/tps65219.h | 345 +++++++++++++++++++++++++++++++++++
>  5 files changed, 660 insertions(+)
>  create mode 100644 drivers/mfd/tps65219.c
>  create mode 100644 include/linux/mfd/tps65219.h

Applied, thanks.

-- 
Lee Jones [李琼斯]