linux-kernel - Re: [PATCH v3] cpumask: limit visibility of FORCE_NR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <xhsmhr0y2yc4u.mognet@vschneid.remote.csb>
Date:   Wed, 16 Nov 2022 18:42:25 +0000
From:   Valentin Schneider <vschneid@...hat.com>
To:     Yury Norov <yury.norov@...il.com>, linux-kernel@...r.kernel.org,
        Geert Uytterhoeven <geert@...ux-m68k.org>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Rasmus Villemoes <linux@...musvillemoes.dk>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Stephen Rothwell <sfr@...b.auug.org.au>,
        Peter Zijlstra <peterz@...radead.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        "Paul E . McKenney" <paulmck@...nel.org>,
        Vlastimil Babka <vbabka@...e.cz>,
        Dmitry Vyukov <dvyukov@...gle.com>,
        Sander Vanheule <sander@...nheule.net>,
        Alexey Klimov <klimov.linux@...il.com>,
        Eric Biggers <ebiggers@...gle.com>
Cc:     Yury Norov <yury.norov@...il.com>
Subject: Re: [PATCH v3] cpumask: limit visibility of FORCE_NR_CPUS

On 16/11/22 09:24, Yury Norov wrote:
> In current form, FORCE_NR_CPUS is visible to all users building their
> kernels, even not experts. It is also set in allmodconfig or allyesconfig,
> which is not a correct behavior.
>
> This patch fixes it. It also changes the parameter short description:
> removes implementation details and highlights the effect of the change.
>
> Suggested-by: Geert Uytterhoeven <geert@...ux-m68k.org>
> Suggested-by: Linus Torvalds <torvalds@...ux-foundation.org>
> Signed-off-by: Yury Norov <yury.norov@...il.com>

Reviewed-by: Valentin Schneider <vschneid@...hat.com>

> ---
> v3: instead of 'choice', use !COMPILE_TEST to disable FORCE_NR_CPUS
>     in all{yes,mod}config, as suggested by Linus.
>  lib/Kconfig | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/lib/Kconfig b/lib/Kconfig
> index 9bbf8a4b2108..404647cd3fac 100644
> --- a/lib/Kconfig
> +++ b/lib/Kconfig
> @@ -529,8 +529,8 @@ config CPUMASK_OFFSTACK
>         stack overflow.
>
>  config FORCE_NR_CPUS
> -       bool "NR_CPUS is set to an actual number of CPUs"
> -       depends on SMP
> +       bool "Set number of CPUs at compile time"
> +       depends on SMP && EXPERT && !COMPILE_TEST
>         help
>           Say Yes if you have NR_CPUS set to an actual number of possible
>           CPUs in your system, not to a default value. This forces the core
> --
> 2.34.1