lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20221116191056.59f901da@jic23-huawei>
Date:   Wed, 16 Nov 2022 19:10:56 +0000
From:   Jonathan Cameron <jic23@...nel.org>
To:     Edmund Berenson <edmund.berenson@...ix.com>
Cc:     Lukasz Zemla <Lukasz.Zemla@...dward.com>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Michael Hennerich <Michael.Hennerich@...log.com>,
        linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] iio/adc: add ad7927 compatibility to ad7923 drivers

On Wed, 16 Nov 2022 11:44:52 +0100
Edmund Berenson <edmund.berenson@...ix.com> wrote:

> The ADC ad7927 is compatible with ad7923 driver,
> add explicit compatible and select appropriate
> channel configuration.
> 
> Suggested-by: Lukasz Zemla <Lukasz.Zemla@...dward.com>
> Signed-off-by: Edmund Berenson <edmund.berenson@...ix.com>
This should match local style for patch formatting (as with the
dt one that has already been commented on).


iio: adc: ad7928: Add ad7927

The ad7927 is software compatible with the existing AD7928
so just add the ID.

S...

Change itself is fine.

> ---
>  drivers/iio/adc/ad7923.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/adc/ad7923.c b/drivers/iio/adc/ad7923.c
> index 9d6bf6d0927a..df72e97dc331 100644
> --- a/drivers/iio/adc/ad7923.c
> +++ b/drivers/iio/adc/ad7923.c
> @@ -1,6 +1,6 @@
>  // SPDX-License-Identifier: GPL-2.0-only
>  /*
> - * AD7904/AD7914/AD7923/AD7924/AD7908/AD7918/AD7928 SPI ADC driver
> + * AD7904/AD7914/AD7923/AD7924/AD7908/AD7918/AD7927/AD7928 SPI ADC driver
>   *
>   * Copyright 2011 Analog Devices Inc (from AD7923 Driver)
>   * Copyright 2012 CS Systemes d'Information
> @@ -367,6 +367,7 @@ static const struct spi_device_id ad7923_id[] = {
>  	{"ad7924", AD7924},
>  	{"ad7908", AD7908},
>  	{"ad7918", AD7918},
> +	{"ad7927", AD7928},
>  	{"ad7928", AD7928},
>  	{}
>  };
> @@ -379,6 +380,7 @@ static const struct of_device_id ad7923_of_match[] = {
>  	{ .compatible = "adi,ad7924", },
>  	{ .compatible = "adi,ad7908", },
>  	{ .compatible = "adi,ad7918", },
> +	{ .compatible = "adi,ad7927", },
>  	{ .compatible = "adi,ad7928", },
>  	{ },
>  };

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ