linux-kernel - Re: [PATCH v2] scripts/kallsyms.c Make the comment up-to-date with current implementation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 16 Nov 2022 21:04:22 +0100
From:   Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
To:     Yuma Ueda <cyan@...0a1e9.dev>
Cc:     linux-kernel@...r.kernel.org, keescook@...omium.org,
        gregkh@...uxfoundation.org, ojeda@...nel.org, boqun.feng@...il.com,
        masahiroy@...nel.org, samitolvanen@...gle.com, ytcoode@...il.com
Subject: Re: [PATCH v2] scripts/kallsyms.c Make the comment up-to-date with
 current implementation

On Tue, Nov 15, 2022 at 10:26 PM Yuma Ueda <cyan@...0a1e9.dev> wrote:
>
> The comment in scripts/kallsyms.c describing the usage of
> scripts/kallsyms does not reflect the latest implementation.
> Fix the comment to be up-to-date with the current implementation.

It may be a good idea to say in the commit message that this is now
equivalent to what the `usage()` function prints (and possibly change
`scripts/kallsyms` to just `kallsyms` to make it exactly equal). In
fact, we could replace the comment with "See usage() function" to
avoid further desyncs... But that is a different patch :)

Also, I am not sure we want to use tabs on the comment -- the rest of
it uses spaces.

Cheers,
Miguel