linux-kernel - Re: [PATCH 1/2] mfd: ax20x: Add suppport for AXP1530 PMIC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <671D1BC5-589B-4AFF-B026-1810F48522FD@somainline.org>
Date:   Wed, 16 Nov 2022 22:07:25 +0100
From:   Martin Botka <martin.botka@...ainline.org>
To:     Lee Jones <lee@...nel.org>
CC:     martin.botka1@...il.com, ~postmarketos/upstreaming@...ts.sr.ht,
        Konrad Dybcio <konrad.dybcio@...ainline.org>,
        AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...ainline.org>,
        Marijn Suijten <marijn.suijten@...ainline.org>,
        Jami Kettunen <jamipkettunen@...ainline.org>,
        Paul Bouchara <paul.bouchara@...ainline.org>,
        Yenda <jtrmal@...il.com>, Chen-Yu Tsai <wens@...e.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] mfd: ax20x: Add suppport for AXP1530 PMIC



On November 16, 2022 4:49:07 PM GMT+01:00, Lee Jones <lee@...nel.org> wrote:
>On Mon, 14 Nov 2022, Martin Botka wrote:
>
>> AXP1530 is a PMIC chip produced by X-Powers and an be connected via
>> I2C or RSB bus.
>> Where AXP313A seems to be closely related so the same driver can be used and
>> seen it only paired with H616 SoC.
>> 
>> Signed-off-by: Martin Botka <martin.botka@...ainline.org>
>> ---
>>  drivers/mfd/axp20x-i2c.c   |  2 ++
>>  drivers/mfd/axp20x-rsb.c   |  1 +
>>  drivers/mfd/axp20x.c       | 63 ++++++++++++++++++++++++++++++++++++++
>>  include/linux/mfd/axp20x.h | 34 ++++++++++++++++++++
>>  4 files changed, 100 insertions(+)
>
>No major concerns.
>
>> +static struct mfd_cell axp1530_cells[] = {
>> +	{
>> +		.id = 0,
>> +		.name = "axp20x-regulator",
>> +	},
>> +};
>
>Why .id = 0?
>

Oh good eye. Yea thats just left over. Will be removed in V2 :)