lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 16 Nov 2022 17:02:17 -0500 From: Peter Xu <peterx@...hat.com> To: James Houghton <jthoughton@...gle.com> Cc: Mike Kravetz <mike.kravetz@...cle.com>, Muchun Song <songmuchun@...edance.com>, David Hildenbrand <david@...hat.com>, David Rientjes <rientjes@...gle.com>, Axel Rasmussen <axelrasmussen@...gle.com>, Mina Almasry <almasrymina@...gle.com>, Zach O'Keefe <zokeefe@...gle.com>, Manish Mishra <manish.mishra@...anix.com>, Naoya Horiguchi <naoya.horiguchi@....com>, "Dr . David Alan Gilbert" <dgilbert@...hat.com>, "Matthew Wilcox (Oracle)" <willy@...radead.org>, Vlastimil Babka <vbabka@...e.cz>, Baolin Wang <baolin.wang@...ux.alibaba.com>, Miaohe Lin <linmiaohe@...wei.com>, Yang Shi <shy828301@...il.com>, Andrew Morton <akpm@...ux-foundation.org>, linux-mm@...ck.org, linux-kernel@...r.kernel.org Subject: Re: [RFC PATCH v2 12/47] hugetlb: add hugetlb_hgm_walk and hugetlb_walk_step On Fri, Oct 21, 2022 at 04:36:28PM +0000, James Houghton wrote: > +/* hugetlb_hgm_walk - walks a high-granularity HugeTLB page table to resolve > + * the page table entry for @addr. > + * > + * @hpte must always be pointing at an hstate-level PTE (or deeper). > + * > + * This function will never walk further if it encounters a PTE of a size > + * less than or equal to @sz. > + * > + * @stop_at_none determines what we do when we encounter an empty PTE. IIUC it is not about empty PTE but swap-or-empty pte? I'm not sure whether it'll be more straightforward to have "bool alloc" just to show whether the caller would like to allocate pgtables when walking the sub-level pgtable until the level specified. In final version of the code I also think we should drop all the "/* stop_at_pte */" comments in the callers. Maybe that already means the meaning of the bool is confusing so we always need a hint. -- Peter Xu
Powered by blists - more mailing lists