linux-kernel - Re: [patch 24/33] PCI/MSI: Provide prepare

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87r0y2o719.ffs@tglx>
Date:   Wed, 16 Nov 2022 23:42:42 +0100
From:   Thomas Gleixner <tglx@...utronix.de>
To:     Bjorn Helgaas <helgaas@...nel.org>
Cc:     LKML <linux-kernel@...r.kernel.org>, x86@...nel.org,
        Joerg Roedel <joro@...tes.org>, Will Deacon <will@...nel.org>,
        linux-pci@...r.kernel.org, Bjorn Helgaas <bhelgaas@...gle.com>,
        Lorenzo Pieralisi <lorenzo.pieralisi@....com>,
        Marc Zyngier <maz@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jason Gunthorpe <jgg@...lanox.com>,
        Dave Jiang <dave.jiang@...el.com>,
        Alex Williamson <alex.williamson@...hat.com>,
        Kevin Tian <kevin.tian@...el.com>,
        Dan Williams <dan.j.williams@...el.com>,
        Logan Gunthorpe <logang@...tatee.com>,
        Ashok Raj <ashok.raj@...el.com>, Jon Mason <jdmason@...zu.us>,
        Allen Hubbe <allenbh@...il.com>,
        "Ahmed S. Darwish" <darwi@...utronix.de>,
        Reinette Chatre <reinette.chatre@...el.com>
Subject: Re: [patch 24/33] PCI/MSI: Provide prepare_desc() MSI domain op

On Wed, Nov 16 2022 at 14:26, Bjorn Helgaas wrote:
> On Fri, Nov 11, 2022 at 02:58:49PM +0100, Thomas Gleixner wrote:
>> Dynamic MSI-X vector allocation post MSI-X allows to allocate vectors at a
>> given index or at any free index in the available table range.
>
> Is "post MSI-X" missing something?  "post MSI-X enablement" or
> something?

Yes. That was the plan.

>> The latter
>> requires that the core code selects the index at descriptor allocation time.
>> 
>> This requires that the PCI/MSI-X specific setup of the MSI-X descriptor,
>> which is partially depending on the chosen index happens after allocation.
>
> Is there a comma missing after "index"?  I.e., setup of the descriptor
> partially depends on the chosen index?  And the above requires that
> setup happens after allocation?

Yes.

Thanks,

        tglx