linux-kernel - Re: [PATCH] [RFC] rtc: y2038: remove broken RTC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <c5e8ab50-aacb-4651-8893-a6dd9edcd155@app.fastmail.com>
Date:   Wed, 16 Nov 2022 08:01:00 +0100
From:   "Arnd Bergmann" <arnd@...db.de>
To:     "Alexandre Belloni" <alexandre.belloni@...tlin.com>,
        "Arnd Bergmann" <arnd@...nel.org>
Cc:     "Alessandro Zummo" <a.zummo@...ertech.it>,
        "Reinier Kuipers" <kuipers.reinier@...il.com>,
        linux-rtc@...r.kernel.org, "Russell King" <linux@...linux.org.uk>,
        "Yang Yingliang" <yangyingliang@...wei.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] [RFC] rtc: y2038: remove broken RTC_HCTOSYS workaround

On Tue, Nov 15, 2022, at 23:08, Alexandre Belloni wrote:
> Hello,
>
> I'm fine with the patch and I'll probably take it, 

Ok, thanks!

> I a an observation though:
>
> On 08/09/2022 13:53:20+0200, Arnd Bergmann wrote:
>> +	 *
>> +	 * Since the kernel has no way of knowing what user space it runs,
>> +	 * warn here whenever the kernel is able to run it.
>> +	 * When CONFIG_COMPAT_32BIT_TIME is disabled, we know that the
>> +	 * system is safe, but unfortunately this this is currently not
>> +	 * supported by musl-1.2.x or most glibc based user space.
>
> I was under the impression that musl never had a 32bit time_t nor used
> the 32bit time APIs so it would not be affected by the bug.
> So I guess the only affected userspace is glibc without _TIME_BITS=64

It's actually the opposite: while new versions of musl only allow
building applications against the time64 interfaces, musl itself
uses a mix of the time32 and time64 system calls, and the musl
maintainer considers turning CONFIG_COMPAT_32BIT_TIME off a
misfeature of the kernel that he does not want to support.

      Arnd