linux-kernel - Re: [PATCH 2/4] workingset: refactor LRU refault to expose refault recency check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202211161412.hq3iCcIL-lkp@intel.com>
Date:   Wed, 16 Nov 2022 15:02:01 +0800
From:   kernel test robot <lkp@...el.com>
To:     Nhat Pham <nphamcs@...il.com>, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org
Cc:     oe-kbuild-all@...ts.linux.dev, hannes@...xchg.org
Subject: Re: [PATCH 2/4] workingset: refactor LRU refault to expose refault
 recency check

Hi Nhat,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on shuah-kselftest/next]
[also build test WARNING on shuah-kselftest/fixes tip/x86/asm arnd-asm-generic/master linus/master v6.1-rc5 next-20221115]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Nhat-Pham/cachestat-a-new-syscall-for-page-cache-state-of-files/20221116-023042
base:   https://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git next
patch link:    https://lore.kernel.org/r/20221115182901.2755368-3-nphamcs%40gmail.com
patch subject: [PATCH 2/4] workingset: refactor LRU refault to expose refault recency check
config: m68k-allyesconfig
compiler: m68k-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/21cc57c8a41260cb193875b3d8668b1ef57cf0c2
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Nhat-Pham/cachestat-a-new-syscall-for-page-cache-state-of-files/20221116-023042
        git checkout 21cc57c8a41260cb193875b3d8668b1ef57cf0c2
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=m68k SHELL=/bin/bash

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

>> mm/workingset.c:248: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
    * Test if the folio is recently evicted.
   mm/workingset.c:408: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
    * Test if the folio is recently evicted by checking if


vim +248 mm/workingset.c

   246	
   247	/**
 > 248	 * Test if the folio is recently evicted.
   249	 *
   250	 * As a side effect, also populates the references with
   251	 * values unpacked from the shadow of the evicted folio.
   252	 */
   253	static bool lru_gen_test_recent(void *shadow, bool file, int *memcgid,
   254		struct pglist_data **pgdat, unsigned long *token, bool *workingset)
   255	{
   256		struct mem_cgroup *eviction_memcg;
   257		struct lruvec *lruvec;
   258		struct lru_gen_struct *lrugen;
   259		unsigned long min_seq;
   260	
   261		unpack_shadow(shadow, memcgid, pgdat, token, workingset);
   262		eviction_memcg = mem_cgroup_from_id(*memcgid);
   263	
   264		lruvec = mem_cgroup_lruvec(eviction_memcg, *pgdat);
   265		lrugen = &lruvec->lrugen;
   266	
   267		min_seq = READ_ONCE(lrugen->min_seq[file]);
   268		return !((*token >> LRU_REFS_WIDTH) != (min_seq & (EVICTION_MASK >> LRU_REFS_WIDTH)));
   269	}
   270	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (282738 bytes)