linux-kernel - Re: [PATCH -next] cacheinfo: Remove of_node_put() for fw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20221116072633.igvqiimtx2pzaa37@bogus>
Date:   Wed, 16 Nov 2022 07:26:33 +0000
From:   Sudeep Holla <sudeep.holla@....com>
To:     Pierre Gondois <pierre.gondois@....com>
Cc:     linux-kernel@...r.kernel.org, Rob.Herring@....com,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "Rafael J . Wysocki" <rafael@...nel.org>,
        Linux-Renesas <linux-renesas-soc@...r.kernel.org>,
        Marek Szyprowski <m.szyprowski@...sung.com>,
        Sudeep Holla <sudeep.holla@....com>,
        Geert Uytterhoeven <geert@...ux-m68k.org>
Subject: Re: [PATCH -next] cacheinfo: Remove of_node_put() for fw_token

On Tue, Nov 15, 2022 at 11:05:20PM +0100, Pierre Gondois wrote:
> fw_token is used for DT/ACPI systems to identify CPUs sharing caches.
> For DT based systems, fw_token is set to a pointer to a DT node.
> 
> commit ("cacheinfo: Decrement refcount in cache_setup_of_node()")

Commit 3da72e18371c ("cacheinfo: Decrement refcount in cache_setup_of_node()")

> doesn't increment the refcount of fw_token anymore in
> cache_setup_of_node(). fw_token is indeed used as a token and not
> as a (struct device_node*), so no reference to fw_token should be
> kept.
> 
> However, [1] is triggered when hotplugging a CPU multiple times
> since cache_shared_cpu_map_remove() decrements the refcount to
> fw_token at each CPU unplugging, eventually reaching 0.
> 
> Remove of_node_put() for fw_token in cache_shared_cpu_map_remove().
> 
> [1]
> [   53.651182] ------------[ cut here ]------------
> [   53.651186] refcount_t: saturated; leaking memory.
> [   53.651223] WARNING: CPU: 4 PID: 32 at lib/refcount.c:22 refcount_warn_saturate (lib/refcount.c:22 (discriminator 3))
> [   53.651241] Modules linked in:
> [   53.651249] CPU: 4 PID: 32 Comm: cpuhp/4 Tainted: G        W          6.1.0-rc1-14091-g9fdf2ca7b9c8 #76
> [   53.651261] Hardware name: ARM LTD ARM Juno Development Platform/ARM Juno Development Platform, BIOS EDK II Oct 31 2022
> [   53.651268] pstate: 600000c5 (nZCv daIF -PAN -UAO -TCO -DIT -SSBS BTYPE=--)
> [   53.651279] pc : refcount_warn_saturate (lib/refcount.c:22 (discriminator 3))
> [   53.651293] lr : refcount_warn_saturate (lib/refcount.c:22 (discriminator 3))
> [...]
> [   53.651513] Call trace:
> [...]
> [   53.651735] of_node_release (drivers/of/dynamic.c:335)
> [   53.651750] kobject_put (lib/kobject.c:677 lib/kobject.c:704 ./include/linux/kref.h:65 lib/kobject.c:721)
> [   53.651762] of_node_put (drivers/of/dynamic.c:49)
> [   53.651776] free_cache_attributes.part.0 (drivers/base/cacheinfo.c:712)
> [   53.651792] cacheinfo_cpu_pre_down (drivers/base/cacheinfo.c:718)
> [   53.651807] cpuhp_invoke_callback (kernel/cpu.c:247 (discriminator 4))
> [   53.651819] cpuhp_thread_fun (kernel/cpu.c:785)
> [   53.651832] smpboot_thread_fn (kernel/smpboot.c:164 (discriminator 3))
> [   53.651847] kthread (kernel/kthread.c:376)
> [   53.651858] ret_from_fork (arch/arm64/kernel/entry.S:861)
> [   53.651869] ---[ end trace 0000000000000000 ]---
>

Please remove the timestamp as they add no value to the commit log.
Also it is worth adding IMO:
Fixes: 3da72e18371c ("cacheinfo: Decrement refcount in cache_setup_of_node()")

I did a quick test and so,
Tested-by: Sudeep Holla <sudeep.holla@....com>
Reviewed-by: Sudeep Holla <sudeep.holla@....com>

Thanks for fixing the quickly and sorry for not noticing the extra of_node_put
even though I thought if it was just incrementing the refcount earlier.

-- 
Regards,
Sudeep