linux-kernel - Re: [PATCH] ARM: mvebu: switch to using gpiod API in pm-board code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y3Q4hVn3GEOm4nMq@lunn.ch>
Date:   Wed, 16 Nov 2022 02:10:29 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc:     Gregory Clement <gregory.clement@...tlin.com>,
        Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ARM: mvebu: switch to using gpiod API in pm-board code

> -		ret = gpio_direction_output(pic_gpios[i], 0);
> -		if (ret < 0) {
> -			gpio_free(pic_gpios[i]);
> +		pic_gpios[i] = fwnode_gpiod_get_index(of_fwnode_handle(np),
> +						      "ctrl", i, GPIOD_OUT_HIGH,
> +						      name);

The old code passes value=0 to gpio_direction_output(). For
fwnode_gpiod_get_index() you pass GPIOD_OUT_HIGH. Is this correct?

	Andrew