linux-kernel - [PATCH v2] PCI: dwc: use devm_request_irq to avoid missing free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Date:   Wed, 16 Nov 2022 17:51:49 +0800
From:   ruanjinjie <ruanjinjie@...wei.com>
To:     <lpieralisi@...nel.org>, <robh@...nel.org>, <kw@...ux.com>,
        <bhelgaas@...gle.com>, <Sergey.Semin@...kalelectronics.ru>,
        <mani@...nel.org>, <kishon@...com>, <naveennaidu479@...il.com>,
        <pali@...nel.org>, <ffclaire1224@...il.com>,
        <linux-pci@...r.kernel.org>, <linux-kernel@...r.kernel.org>
CC:     <ruanjinjie@...wei.com>
Subject: [PATCH v2] PCI: dwc: use devm_request_irq to avoid missing free_irq()

free_irq() is missing in ks_pcie_remove() and error path
in ks_pcie_probe(), use devm_request_irq to fix that.

Fixes: 49229238ab47 ("PCI: keystone: Cleanup PHY handling")
Signed-off-by: ruanjinjie <ruanjinjie@...wei.com>
---
v2: use devm_request_irq instead of adding free_irq() to fix the problem.
---
 drivers/pci/controller/dwc/pci-keystone.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pci/controller/dwc/pci-keystone.c b/drivers/pci/controller/dwc/pci-keystone.c
index 78818853af9e..25e1b3fc1877 100644
--- a/drivers/pci/controller/dwc/pci-keystone.c
+++ b/drivers/pci/controller/dwc/pci-keystone.c
@@ -1166,7 +1166,7 @@ static int __init ks_pcie_probe(struct platform_device *pdev)
 	if (irq < 0)
 		return irq;
 
-	ret = request_irq(irq, ks_pcie_err_irq_handler, IRQF_SHARED,
+	ret = devm_request_irq(dev, irq, ks_pcie_err_irq_handler, IRQF_SHARED,
 			  "ks-pcie-error-irq", ks_pcie);
 	if (ret < 0) {
 		dev_err(dev, "failed to request error IRQ %d\n",
-- 
2.25.1