linux-kernel - [PATCH] memory: tegra: Remove early boot SID override programming

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20221116102442.28194-1-amhetre@nvidia.com>
Date:   Wed, 16 Nov 2022 15:54:42 +0530
From:   Ashish Mhetre <amhetre@...dia.com>
To:     <krzysztof.kozlowski@...aro.org>, <thierry.reding@...il.com>,
        <jonathanh@...dia.com>, <dmitry.osipenko@...labora.com>,
        <linux-kernel@...r.kernel.org>, <linux-tegra@...r.kernel.org>
CC:     Ashish Mhetre <amhetre@...dia.com>
Subject: [PATCH] memory: tegra: Remove early boot SID override programming

SID override is programmed on-demand during probe_finalize() call of
IOMMU which is done in tegra186_mc_client_sid_override() in this same
file. This function does it more correctly by checking if write is
permitted on SID override register. It also checks if SID override
register is already written with correct value and skips re-writing it
in that case.
Also, on newer Tegra releases SID override programming is done by
bootloader.
Hence, removing the early boot SID override programming of all clients.

Fixes: 393d66fd2cac ("memory: tegra: Implement SID override programming")
Signed-off-by: Ashish Mhetre <amhetre@...dia.com>
---
 drivers/memory/tegra/tegra186.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/memory/tegra/tegra186.c b/drivers/memory/tegra/tegra186.c
index 62477e592bf5..870273d343d6 100644
--- a/drivers/memory/tegra/tegra186.c
+++ b/drivers/memory/tegra/tegra186.c
@@ -85,8 +85,6 @@ static int tegra186_mc_probe(struct tegra_mc *mc)
 	if (err < 0)
 		return err;

-	tegra186_mc_program_sid(mc);
-
 	return 0;
 }

-- 
2.17.1