[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Y3S9KzTE1/UQDmJl@sirena.org.uk>
Date: Wed, 16 Nov 2022 10:36:27 +0000
From: Mark Brown <broonie@...nel.org>
To: Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc: Liam Girdwood <lgirdwood@...il.com>, linux-kernel@...r.kernel.org,
alsa-devel@...a-project.org
Subject: Re: [PATCH 01/11] ASoC: ak5386: switch to using gpiod API
On Tue, Nov 15, 2022 at 09:38:07PM -0800, Dmitry Torokhov wrote:
> Switch the driver from legacy gpio API that is deprecated to the newer
> gpiod API that respects line polarities described in ACPI/DT.
> - if (gpio_is_valid(priv->reset_gpio))
> - gpio_set_value(priv->reset_gpio, 1);
> + if (priv->reset_gpio)
> + gpiod_set_value(priv->reset_gpio, 0);
How are we ensuring that people have described signals as active
low/high in existing DTs, and are we positive that the signal is
described as active low for all devices? In particular if the
signal is described as a reset signal then it's active high even
if we want it low while the device is actually in use.
Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)
Powered by blists - more mailing lists