linux-kernel - Re: [tip: locking/urgent] locking: Fix qspinlock/x86 inline asm error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Y3S96d8vrEEQe1XH@hirez.programming.kicks-ass.net>
Date:   Wed, 16 Nov 2022 11:39:37 +0100
From:   Peter Zijlstra <peterz@...radead.org>
To:     Juergen Gross <jgross@...e.com>
Cc:     linux-kernel@...r.kernel.org, linux-tip-commits@...r.kernel.org,
        Guo Jin <guoj17@...natelecom.cn>,
        Nathan Chancellor <nathan@...nel.org>, x86@...nel.org
Subject: Re: [tip: locking/urgent] locking: Fix qspinlock/x86 inline asm error

On Wed, Nov 16, 2022 at 10:40:10AM +0100, Juergen Gross wrote:
> On 16.11.22 10:21, tip-bot2 for Guo Jin wrote:
> > The following commit has been merged into the locking/urgent branch of tip:
> > 
> > Commit-ID:     23df39fc6a36183af5e6e4f47523f1ad2cdc1d30
> > Gitweb:        https://git.kernel.org/tip/23df39fc6a36183af5e6e4f47523f1ad2cdc1d30
> > Author:        Guo Jin <guoj17@...natelecom.cn>
> > AuthorDate:    Tue, 08 Nov 2022 14:01:26 +08:00
> > Committer:     Peter Zijlstra <peterz@...radead.org>
> > CommitterDate: Wed, 16 Nov 2022 10:18:09 +01:00
> > 
> > locking: Fix qspinlock/x86 inline asm error
> > 
> > When compiling linux 6.1.0-rc3 configured with CONFIG_64BIT=y and
> > CONFIG_PARAVIRT_SPINLOCKS=y on x86_64 using LLVM 11.0, an error:
> > "<inline asm> error: changed section flags for .spinlock.text,
> > expected:: 0x6" occurred.
> > 
> > The reason is the .spinlock.text in kernel/locking/qspinlock.o
> > is used many times, but its flags are omitted in subsequent use.
> > 
> > LLVM 11.0 assembler didn't permit to
> > leave out flags in subsequent uses of the same sections.
> > 
> > So this patch adds the corresponding flags to avoid above error.
> > 
> > Fixes: 501f7f69bca1 ("locking: Add __lockfunc to slow path functions")
> > Signed-off-by: Guo Jin <guoj17@...natelecom.cn>
> > Signed-off-by: Peter Zijlstra (Intel) <peterz@...radead.org>
> > Reviewed-by: Nathan Chancellor <nathan@...nel.org>
> > Link: https://lore.kernel.org/r/20221108060126.2505-1-guoj17@chinatelecom.cn
> 
> Wouldn't it be better to take my more generic patch [1] instead?
> 
> [1]: https://lore.kernel.org/lkml/20221109134418.6516-1-jgross@suse.com/

Durr, I missed that, lemme go stare at it.