linux-kernel - Re: linux-next: build failure after merge of the arm64 tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <774c9e6b-a8f4-66fe-aae0-d1cefedf7df3@arm.com>
Date:   Wed, 16 Nov 2022 10:49:35 +0000
From:   Suzuki K Poulose <suzuki.poulose@....com>
To:     Besar Wicaksono <bwicaksono@...dia.com>,
        Stephen Rothwell <sfr@...b.auug.org.au>,
        Catalin Marinas <catalin.marinas@....com>,
        Will Deacon <will@...nel.org>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux Next Mailing List <linux-next@...r.kernel.org>
Subject: Re: linux-next: build failure after merge of the arm64 tree

On 15/11/2022 23:52, Besar Wicaksono wrote:
> 
> 
>> -----Original Message-----
>> From: Stephen Rothwell <sfr@...b.auug.org.au>
>> Sent: Tuesday, November 15, 2022 4:04 PM
>> To: Catalin Marinas <catalin.marinas@....com>; Will Deacon
>> <will@...nel.org>
>> Cc: Besar Wicaksono <bwicaksono@...dia.com>; Linux Kernel Mailing List
>> <linux-kernel@...r.kernel.org>; Linux Next Mailing List <linux-
>> next@...r.kernel.org>
>> Subject: linux-next: build failure after merge of the arm64 tree
>>
>> Hi all,
>>
>> After merging the arm64 tree, today's linux-next build (x86_64
>> allmodconfig) failed like this:
>>
>> drivers/perf/arm_cspmu/arm_cspmu.c: In function 'arm_cspmu_get_cpus':
>> drivers/perf/arm_cspmu/arm_cspmu.c:1114:29: error: implicit declaration of
>> function 'get_acpi_id_for_cpu' [-Werror=implicit-function-declaration]
>>   1114 |                             get_acpi_id_for_cpu(cpu)) {
>>        |                             ^~~~~~~~~~~~~~~~~~~
>>
> 
> +CC Suzuki for awareness.
> 
> This function is used for searching CPU with matching ACPI Processor ID in PPTT.
> I will check if adding PPTT dependency to arm_cspmu would resolve this issue.

Please make this dependent on ARM64. That should resolve the failure.
As such the helper is available with ARM64 && ACPI.

Suzuki

> 
> Regards,
> Besar
> 
>> Caused by commit
>>
>>    e37dfd65731d ("perf: arm_cspmu: Add support for ARM CoreSight PMU
>> driver")
>>
>> I have used the arm64 tree from next-20221115 for today.
>>
>> --
>> Cheers,
>> Stephen Rothwell