linux-kernel - Re: [PATCH mm-unstable v1 16/20] mm/frame-vector: remove FOLL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y3TAd14jCBSKeqsL@phenom.ffwll.local>
Date:   Wed, 16 Nov 2022 11:50:31 +0100
From:   Daniel Vetter <daniel@...ll.ch>
To:     David Hildenbrand <david@...hat.com>
Cc:     linux-kernel@...r.kernel.org, linux-ia64@...r.kernel.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        dri-devel@...ts.freedesktop.org, Hans Verkuil <hverkuil@...all.nl>,
        linux-mm@...ck.org, Nadav Amit <namit@...are.com>,
        linux-kselftest@...r.kernel.org, sparclinux@...r.kernel.org,
        Shuah Khan <shuah@...nel.org>,
        Marek Szyprowski <m.szyprowski@...sung.com>,
        Andrea Arcangeli <aarcange@...hat.com>,
        linux-samsung-soc@...r.kernel.org, linux-rdma@...r.kernel.org,
        x86@...nel.org, Hugh Dickins <hughd@...gle.com>,
        Matthew Wilcox <willy@...radead.org>,
        Christoph Hellwig <hch@...radead.org>,
        Jason Gunthorpe <jgg@...pe.ca>,
        Vlastimil Babka <vbabka@...e.cz>, linux-media@...r.kernel.org,
        Arnd Bergmann <arnd@...db.de>,
        John Hubbard <jhubbard@...dia.com>,
        linux-um@...ts.infradead.org, etnaviv@...ts.freedesktop.org,
        Alex Williamson <alex.williamson@...hat.com>,
        Peter Xu <peterx@...hat.com>,
        Muchun Song <songmuchun@...edance.com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        linux-arm-kernel@...ts.infradead.org,
        linuxppc-dev@...ts.ozlabs.org, Oded Gabbay <ogabbay@...nel.org>,
        linux-mips@...r.kernel.org, Tomasz Figa <tfiga@...omium.org>,
        linux-perf-users@...r.kernel.org,
        linux-security-module@...r.kernel.org, linux-alpha@...r.kernel.org,
        linux-fsdevel@...r.kernel.org,
        Andrew Morton <akpm@...ux-foundation.org>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Mike Kravetz <mike.kravetz@...cle.com>
Subject: Re: [PATCH mm-unstable v1 16/20] mm/frame-vector: remove FOLL_FORCE
 usage

On Wed, Nov 16, 2022 at 11:26:55AM +0100, David Hildenbrand wrote:
> FOLL_FORCE is really only for ptrace access. According to commit
> 707947247e95 ("media: videobuf2-vmalloc: get_userptr: buffers are always
> writable"), get_vaddr_frames() currently pins all pages writable as a
> workaround for issues with read-only buffers.
> 
> FOLL_FORCE, however, seems to be a legacy leftover as it predates
> commit 707947247e95 ("media: videobuf2-vmalloc: get_userptr: buffers are
> always writable"). Let's just remove it.
> 
> Once the read-only buffer issue has been resolved, FOLL_WRITE could
> again be set depending on the DMA direction.
> 
> Cc: Hans Verkuil <hverkuil@...all.nl>
> Cc: Marek Szyprowski <m.szyprowski@...sung.com>
> Cc: Tomasz Figa <tfiga@...omium.org>
> Cc: Marek Szyprowski <m.szyprowski@...sung.com>
> Cc: Mauro Carvalho Chehab <mchehab@...nel.org>
> Signed-off-by: David Hildenbrand <david@...hat.com>

Also code I looked at while looking at follow_pfn stuff

Reviewed-by: Daniel Vetter <daniel.vetter@...ll.ch>

> ---
>  drivers/media/common/videobuf2/frame_vector.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/common/videobuf2/frame_vector.c b/drivers/media/common/videobuf2/frame_vector.c
> index 542dde9d2609..062e98148c53 100644
> --- a/drivers/media/common/videobuf2/frame_vector.c
> +++ b/drivers/media/common/videobuf2/frame_vector.c
> @@ -50,7 +50,7 @@ int get_vaddr_frames(unsigned long start, unsigned int nr_frames,
>  	start = untagged_addr(start);
>  
>  	ret = pin_user_pages_fast(start, nr_frames,
> -				  FOLL_FORCE | FOLL_WRITE | FOLL_LONGTERM,
> +				  FOLL_WRITE | FOLL_LONGTERM,
>  				  (struct page **)(vec->ptrs));
>  	if (ret > 0) {
>  		vec->got_ref = true;
> -- 
> 2.38.1
> 

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch