linux-kernel - Re: [PATCH 2/4] dt-bindings: pinctrl: qcom,tlmm-common: document i2c pull property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <af028226-3678-86f6-6a02-3bd4e71e137b@linaro.org>
Date:   Wed, 16 Nov 2022 12:11:32 +0100
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Abel Vesa <abel.vesa@...aro.org>, Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio <konrad.dybcio@...aro.org>,
        Linus Walleij <linus.walleij@...aro.org>,
        Rob Herring <robh@...nel.org>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        devicetree@...r.kernel.org, linux-arm-msm@...r.kernel.org,
        "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
        Neil Armstrong <neil.armstrong@...aro.org>
Subject: Re: [PATCH 2/4] dt-bindings: pinctrl: qcom,tlmm-common: document i2c
 pull property

On 16/11/2022 11:57, Abel Vesa wrote:
> From: Neil Armstrong <neil.armstrong@...aro.org>
> 
> Document the new i2c_pull property introduced for SM8550 setting
> an I2C specific pull mode on I2C able pins.
> 
> Signed-off-by: Neil Armstrong <neil.armstrong@...aro.org>

Your SoB is missing and this patch cannot be before the first.

> ---
>  .../devicetree/bindings/pinctrl/qcom,tlmm-common.yaml          | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,tlmm-common.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,tlmm-common.yaml
> index e1354f0c64f8..eddd58eafba9 100644
> --- a/Documentation/devicetree/bindings/pinctrl/qcom,tlmm-common.yaml
> +++ b/Documentation/devicetree/bindings/pinctrl/qcom,tlmm-common.yaml
> @@ -77,6 +77,9 @@ $defs:
>        input-enable: true
>        output-high: true
>        output-low: true
> +      qcom,i2c-pull:
> +        type: boolean
> +        description: enable bias pull feature designed for i2c on pin

s/i2c/I2C/

>  
>      allOf:
>        - $ref: pincfg-node.yaml#

Best regards,
Krzysztof