[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <6374483F.3060604@hisilicon.com>
Date: Wed, 16 Nov 2022 10:17:35 +0800
From: Wei Xu <xuwei5@...ilicon.com>
To: Pierre Gondois <pierre.gondois@....com>,
<linux-kernel@...r.kernel.org>
CC: Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Florian Fainelli <f.fainelli@...il.com>,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@...adcom.com>,
Ray Jui <rjui@...adcom.com>,
Scott Branden <sbranden@...adcom.com>,
Tsahee Zidenberg <tsahee@...apurnalabs.com>,
Antoine Tenart <atenart@...nel.org>,
Brijesh Singh <brijeshkumar.singh@....com>,
Suravee Suthikulpanit <suravee.suthikulpanit@....com>,
Tom Lendacky <thomas.lendacky@....com>,
Neil Armstrong <neil.armstrong@...aro.org>,
Kevin Hilman <khilman@...libre.com>,
Jerome Brunet <jbrunet@...libre.com>,
Martin Blumenstingl <martin.blumenstingl@...glemail.com>,
Khuong Dinh <khuong@...amperecomputing.com>,
Liviu Dudau <liviu.dudau@....com>,
Sudeep Holla <sudeep.holla@....com>,
Lorenzo Pieralisi <lpieralisi@...nel.org>,
William Zhang <william.zhang@...adcom.com>,
Anand Gore <anand.gore@...adcom.com>,
Kursad Oney <kursad.oney@...adcom.com>,
Rafał Miłecki <rafal@...ecki.pl>,
Alim Akhtar <alim.akhtar@...sung.com>,
Shawn Guo <shawnguo@...nel.org>, Li Yang <leoyang.li@....com>,
Sascha Hauer <s.hauer@...gutronix.de>,
Pengutronix Kernel Team <kernel@...gutronix.de>,
Fabio Estevam <festevam@...il.com>,
NXP Linux Team <linux-imx@....com>,
Chester Lin <clin@...e.com>,
Andreas Färber <afaerber@...e.de>,
Matthias Brugger <mbrugger@...e.com>,
NXP S32 Linux Team <s32@....com>,
Chanho Min <chanho.min@....com>, Andrew Lunn <andrew@...n.ch>,
Gregory Clement <gregory.clement@...tlin.com>,
Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>,
Lars Povlsen <lars.povlsen@...rochip.com>,
Steen Hegelund <Steen.Hegelund@...rochip.com>,
Daniel Machon <daniel.machon@...rochip.com>,
<UNGLinuxDriver@...rochip.com>,
Avi Fishman <avifishman70@...il.com>,
Tomer Maimon <tmaimon77@...il.com>,
Tali Perry <tali.perry1@...il.com>,
Patrick Venture <venture@...gle.com>,
Nancy Yuen <yuenn@...gle.com>,
Benjamin Fair <benjaminfair@...gle.com>,
Thierry Reding <thierry.reding@...il.com>,
Jonathan Hunter <jonathanh@...dia.com>,
Andy Gross <agross@...nel.org>,
Bjorn Andersson <andersson@...nel.org>,
Konrad Dybcio <konrad.dybcio@...ainline.org>,
Geert Uytterhoeven <geert+renesas@...der.be>,
Magnus Damm <magnus.damm@...il.com>,
Heiko Stuebner <heiko@...ech.de>,
Kunihiko Hayashi <hayashi.kunihiko@...ionext.com>,
Masami Hiramatsu <mhiramat@...nel.org>,
Jisheng Zhang <jszhang@...nel.org>, Nishanth Menon <nm@...com>,
Vignesh Raghavendra <vigneshr@...com>,
Tero Kristo <kristo@...nel.org>,
Viorel Suman <viorel.suman@....com>,
Abel Vesa <abelvesa@...nel.org>, Ming Qian <ming.qian@....com>,
Shijie Qin <shijie.qin@....com>, Peng Fan <peng.fan@....com>,
Shenwei Wang <shenwei.wang@....com>,
Tim Harvey <tharvey@...eworks.com>,
Lucas Stach <l.stach@...gutronix.de>,
Adam Ford <aford173@...il.com>,
Richard Zhu <hongxing.zhu@....com>, Li Jun <jun.li@....com>,
Markus Niebel <Markus.Niebel@...tq-group.com>,
Joakim Zhang <qiangqing.zhang@....com>,
Marek Vasut <marex@...x.de>,
Laurent Pinchart <laurent.pinchart@...asonboard.com>,
Alexander Stein <alexander.stein@...tq-group.com>,
Paul Elder <paul.elder@...asonboard.com>,
Martin Kepplinger <martink@...teo.de>,
David Heidelberg <david@...t.cz>,
Oliver Graute <oliver.graute@...oconnector.com>,
Liu Ying <victor.liu@....com>, Jacky Bai <ping.bai@....com>,
Clark Wang <xiaoning.wang@....com>,
Wei Fang <wei.fang@....com>,
Chris Packham <chris.packham@...iedtelesis.co.nz>,
Vadym Kochan <vadym.kochan@...ision.eu>,
Sameer Pujar <spujar@...dia.com>,
Akhil R <akhilrajeev@...dia.com>,
Mikko Perttunen <mperttunen@...dia.com>,
Prathamesh Shete <pshete@...dia.com>,
Sumit Gupta <sumitg@...dia.com>,
Diogo Ivo <diogo.ivo@...nico.ulisboa.pt>,
Vidya Sagar <vidyas@...dia.com>,
Ashish Mhetre <amhetre@...dia.com>,
Johan Jonker <jbx6244@...il.com>,
Christopher Obbard <chris.obbard@...labora.com>,
Ezequiel Garcia <ezequiel@...guardiasur.com.ar>,
Aswani Reddy <aswani.reddy@...sung.com>,
Shashank Prashar <s.prashar@...sung.com>,
Andi Shyti <andi@...zian.org>, <devicetree@...r.kernel.org>,
<linux-rpi-kernel@...ts.infradead.org>,
<linux-arm-kernel@...ts.infradead.org>,
<linux-amlogic@...ts.infradead.org>,
<linux-samsung-soc@...r.kernel.org>,
<linux-mediatek@...ts.infradead.org>, <openbmc@...ts.ozlabs.org>,
<linux-tegra@...r.kernel.org>, <linux-arm-msm@...r.kernel.org>,
<linux-realtek-soc@...ts.infradead.org>,
<linux-renesas-soc@...r.kernel.org>,
<linux-rockchip@...ts.infradead.org>
Subject: Re: [PATCH v2 09/23] arm64: dts: Update cache properties for hisilicon
Hi Pierre,
On 2022/11/7 23:57, Pierre Gondois wrote:
> The DeviceTree Specification v0.3 specifies that the cache node
> 'compatible' and 'cache-level' properties are 'required'. Cf.
> s3.8 Multi-level and Shared Cache Nodes
> The 'cache-unified' property should be present if one of the
> properties for unified cache is present ('cache-size', ...).
>
> Update the Device Trees accordingly.
>
> Signed-off-by: Pierre Gondois <pierre.gondois@....com>
Applied to the HiSilicon arm64 dt tree.
Thanks!
Best Regards,
Wei
> ---
> arch/arm64/boot/dts/hisilicon/hi3660.dtsi | 2 ++
> arch/arm64/boot/dts/hisilicon/hi6220.dtsi | 2 ++
> arch/arm64/boot/dts/hisilicon/hip05.dtsi | 4 ++++
> arch/arm64/boot/dts/hisilicon/hip06.dtsi | 4 ++++
> arch/arm64/boot/dts/hisilicon/hip07.dtsi | 16 ++++++++++++++++
> 5 files changed, 28 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/hisilicon/hi3660.dtsi b/arch/arm64/boot/dts/hisilicon/hi3660.dtsi
> index 8343d0cedde3..a57f35eb5ef6 100644
> --- a/arch/arm64/boot/dts/hisilicon/hi3660.dtsi
> +++ b/arch/arm64/boot/dts/hisilicon/hi3660.dtsi
> @@ -203,10 +203,12 @@ CLUSTER_SLEEP_1: cluster-sleep-1 {
>
> A53_L2: l2-cache0 {
> compatible = "cache";
> + cache-level = <2>;
> };
>
> A73_L2: l2-cache1 {
> compatible = "cache";
> + cache-level = <2>;
> };
> };
>
> diff --git a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
> index ae0a7cfeeb47..f6d3202b0d1a 100644
> --- a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
> +++ b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
> @@ -186,10 +186,12 @@ cpu7: cpu@103 {
>
> CLUSTER0_L2: l2-cache0 {
> compatible = "cache";
> + cache-level = <2>;
> };
>
> CLUSTER1_L2: l2-cache1 {
> compatible = "cache";
> + cache-level = <2>;
> };
> };
>
> diff --git a/arch/arm64/boot/dts/hisilicon/hip05.dtsi b/arch/arm64/boot/dts/hisilicon/hip05.dtsi
> index 7b2abd10d3d6..5b2b1bfd0d2a 100644
> --- a/arch/arm64/boot/dts/hisilicon/hip05.dtsi
> +++ b/arch/arm64/boot/dts/hisilicon/hip05.dtsi
> @@ -211,18 +211,22 @@ cpu15: cpu@...03 {
>
> cluster0_l2: l2-cache0 {
> compatible = "cache";
> + cache-level = <2>;
> };
>
> cluster1_l2: l2-cache1 {
> compatible = "cache";
> + cache-level = <2>;
> };
>
> cluster2_l2: l2-cache2 {
> compatible = "cache";
> + cache-level = <2>;
> };
>
> cluster3_l2: l2-cache3 {
> compatible = "cache";
> + cache-level = <2>;
> };
> };
>
> diff --git a/arch/arm64/boot/dts/hisilicon/hip06.dtsi b/arch/arm64/boot/dts/hisilicon/hip06.dtsi
> index 2f8b03b0d365..291c2ee38288 100644
> --- a/arch/arm64/boot/dts/hisilicon/hip06.dtsi
> +++ b/arch/arm64/boot/dts/hisilicon/hip06.dtsi
> @@ -211,18 +211,22 @@ cpu15: cpu@...03 {
>
> cluster0_l2: l2-cache0 {
> compatible = "cache";
> + cache-level = <2>;
> };
>
> cluster1_l2: l2-cache1 {
> compatible = "cache";
> + cache-level = <2>;
> };
>
> cluster2_l2: l2-cache2 {
> compatible = "cache";
> + cache-level = <2>;
> };
>
> cluster3_l2: l2-cache3 {
> compatible = "cache";
> + cache-level = <2>;
> };
> };
>
> diff --git a/arch/arm64/boot/dts/hisilicon/hip07.dtsi b/arch/arm64/boot/dts/hisilicon/hip07.dtsi
> index 1a16662f8867..b8746fb959b5 100644
> --- a/arch/arm64/boot/dts/hisilicon/hip07.dtsi
> +++ b/arch/arm64/boot/dts/hisilicon/hip07.dtsi
> @@ -842,66 +842,82 @@ cpu63: cpu@...03 {
>
> cluster0_l2: l2-cache0 {
> compatible = "cache";
> + cache-level = <2>;
> };
>
> cluster1_l2: l2-cache1 {
> compatible = "cache";
> + cache-level = <2>;
> };
>
> cluster2_l2: l2-cache2 {
> compatible = "cache";
> + cache-level = <2>;
> };
>
> cluster3_l2: l2-cache3 {
> compatible = "cache";
> + cache-level = <2>;
> };
>
> cluster4_l2: l2-cache4 {
> compatible = "cache";
> + cache-level = <2>;
> };
>
> cluster5_l2: l2-cache5 {
> compatible = "cache";
> + cache-level = <2>;
> };
>
> cluster6_l2: l2-cache6 {
> compatible = "cache";
> + cache-level = <2>;
> };
>
> cluster7_l2: l2-cache7 {
> compatible = "cache";
> + cache-level = <2>;
> };
>
> cluster8_l2: l2-cache8 {
> compatible = "cache";
> + cache-level = <2>;
> };
>
> cluster9_l2: l2-cache9 {
> compatible = "cache";
> + cache-level = <2>;
> };
>
> cluster10_l2: l2-cache10 {
> compatible = "cache";
> + cache-level = <2>;
> };
>
> cluster11_l2: l2-cache11 {
> compatible = "cache";
> + cache-level = <2>;
> };
>
> cluster12_l2: l2-cache12 {
> compatible = "cache";
> + cache-level = <2>;
> };
>
> cluster13_l2: l2-cache13 {
> compatible = "cache";
> + cache-level = <2>;
> };
>
> cluster14_l2: l2-cache14 {
> compatible = "cache";
> + cache-level = <2>;
> };
>
> cluster15_l2: l2-cache15 {
> compatible = "cache";
> + cache-level = <2>;
> };
> };
>
>
Powered by blists - more mailing lists