linux-kernel - Re: [PATCH 2/4] dt-bindings: qcom-qce: document clocks and clock-names as optional

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 16 Nov 2022 12:52:05 +0100
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Neil Armstrong <neil.armstrong@...aro.org>,
        Vinod Koul <vkoul@...nel.org>, Andy Gross <agross@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Bjorn Andersson <andersson@...nel.org>,
        Thara Gopinath <thara.gopinath@...il.com>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        Bhupesh Sharma <bhupesh.sharma@...aro.org>,
        Konrad Dybcio <konrad.dybcio@...ainline.org>
Cc:     linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org, dmaengine@...r.kernel.org,
        Abel Vesa <abel.vesa@...aro.org>, linux-arm-msm@...r.kernel.org
Subject: Re: [PATCH 2/4] dt-bindings: qcom-qce: document clocks and
 clock-names as optional

On 16/11/2022 11:23, Neil Armstrong wrote:
> On certain Snapdragon processors, the crypto engine clocks are enabled by

If by "enabled" you mean "controlled", then looks fine. Otherwise
without exclusive control by firmware, clock enabled e.g. by firmware or
bootloader might still be disabled by SoC. Which case is here?

Probably we should have dedicated compatibles for that.

Best regards,
Krzysztof