linux-kernel - Re: [PATCH] dt-bindings: thermal: qcom-tsens: simplify if:then: clauses

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <89e0f9b7-e06d-ea26-6e45-d22a74371f4b@linaro.org>
Date:   Thu, 17 Nov 2022 16:31:19 +0100
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Stephan Gerhold <stephan@...hold.net>
Cc:     Amit Kucheria <amitk@...nel.org>,
        Thara Gopinath <thara.gopinath@...il.com>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio <konrad.dybcio@...aro.org>,
        "Rafael J. Wysocki" <rafael@...nel.org>,
        Daniel Lezcano <daniel.lezcano@...aro.org>,
        Zhang Rui <rui.zhang@...el.com>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        linux-pm@...r.kernel.org, linux-arm-msm@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        Neil Armstrong <neil.armstrong@...aro.org>
Subject: Re: [PATCH] dt-bindings: thermal: qcom-tsens: simplify if:then:
 clauses

On 17/11/2022 15:28, Stephan Gerhold wrote:
> On Thu, Nov 17, 2022 at 02:02:54PM +0100, Krzysztof Kozlowski wrote:
>> Most of the device-specific compatibles have generic fallbacks like
>> qcom,tsens-v1 or qcom,tsens-v2.  The if:then: block mentions these
>> fallbacks, so drop redundant entries for specific compatibles.
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
>>
>> ---
>>
>> Cc: Neil Armstrong <neil.armstrong@...aro.org>
>> ---
>>  .../devicetree/bindings/thermal/qcom-tsens.yaml  | 16 ----------------
>>  1 file changed, 16 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
>> index f0bd4b979e28..c9949713f714 100644
>> --- a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
>> +++ b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
>> @@ -118,12 +118,7 @@ allOf:
>>            contains:
>>              enum:
>>                - qcom,ipq8064-tsens
>> -              - qcom,mdm9607-tsens
>> -              - qcom,msm8916-tsens
>>                - qcom,msm8960-tsens
>> -              - qcom,msm8974-tsens
>> -              - qcom,msm8976-tsens
>> -              - qcom,qcs404-tsens
>>                - qcom,tsens-v0_1
>>                - qcom,tsens-v1
>>      then:
> 
> FWIW: I submitted the same patch for this part a couple of months ago,
> it was never applied for some reason:
> https://lore.kernel.org/linux-arm-msm/20220627131415.2868938-2-stephan.gerhold@kernkonzept.com/

Indeed, somehow Daniel didn't take it. Your patch should go instead, if
you rebase and include new hunks (like my patch).

> 
>> @@ -140,17 +135,6 @@ allOf:
>>          compatible:
>>            contains:
>>              enum:
>> -              - qcom,msm8953-tsens
>> -              - qcom,msm8996-tsens
>> -              - qcom,msm8998-tsens
>> -              - qcom,sc7180-tsens
>> -              - qcom,sc7280-tsens
>> -              - qcom,sc8180x-tsens
>> -              - qcom,sdm630-tsens
>> -              - qcom,sdm845-tsens
>> -              - qcom,sm8150-tsens
>> -              - qcom,sm8250-tsens
>> -              - qcom,sm8350-tsens
>>                - qcom,tsens-v2
>>      then:
>>        properties:
>>
> 
> This part was not present back then though. Looks like this was
> introduced recently in "dt-bindings: thermal: tsens: Add ipq8074
> compatible".
> 
> I don't mind if you take this patch instead of mine. Feel free to add my
> 
> Reviewed-by: Stephan Gerhold <stephan@...hold.net>
> 
> Thanks,
> Stephan

Best regards,
Krzysztof