[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <a21a7a1b749d0c7e8f7942fe02dd4b6fcd3e97f6.camel@linux.intel.com>
Date: Thu, 17 Nov 2022 08:00:42 -0800
From: "David E. Box" <david.e.box@...ux.intel.com>
To: Hans de Goede <hdegoede@...hat.com>, markgross@...nel.org,
andriy.shevchenko@...ux.intel.com, srinivas.pandruvada@...el.com
Cc: platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/9] Extend Intel On Demand (SDSi) support
On Thu, 2022-11-17 at 15:01 +0100, Hans de Goede wrote:
> Hi David,
>
> On 11/1/22 20:10, David E. Box wrote:
> > Intel Software Defined Silicon (SDSi) is now known as Intel On Demand. The
> > following patches do the following:
> >
> > 1. Identify the driver/tools as Intel On Demand. Only text descriptions are
> > changed. Kconfig and filenames remain the same.
> > 2. Perform some attribute cleanup by preventing the showing of files when
> > features are not supported.
> > 3. Adds support for a new GUID. GUIDs are used to identify the layout of
> > the On Demand registers in sysfs. Layouts are described in the
> > documentation on github [1].
> > 4. Add support for reading On Demand meter certificates in sysfs.
> > 5. The rest of the patches modify the existing tool to support discovery
> > and reading of On Demand registers and the meter certificate.
> >
> > [1] https://github.com/intel/intel-sdsi/blob/master/os-interface.rst
> >
> > David E. Box (9):
> > platform/x86/intel/sdsi: Add Intel On Demand text
> > platform/x86/intel/sdsi: Hide attributes if hardware doesn't support
> > platform/x86/intel/sdsi: Support different GUIDs
> > platform/x86/intel/sdsi: Add meter certificate support
> > tools/arch/x86: intel_sdsi: Add support for reading state certificates
> > tools/arch/x86: intel_sdsi: Add Intel On Demand text
> > tools/arch/x86: intel_sdsi: Read more On Demand registers
> > tools/arch/x86: intel_sdsi: Add support for new GUID
> > tools/arch/x86: intel_sdsi: Add support for reading meter certificates
>
> Thank you, over all this looks good. I have some small remarks
> on patches 4, 8 and 9 see my replies to those.
>
> Please prepare a v2 addressing Andy's + my review remarks and get
> that v2 to me no later then next week Tuesday, then I can still
> merge this in time for 6.2 .
Will do. Thanks Hans, Andy.
>
> Regards,
>
> Hans
>
>
Powered by blists - more mailing lists