[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <3ab0a069-355c-b3a7-450b-22e58d5f1ea8@gmail.com>
Date: Thu, 17 Nov 2022 17:02:51 +0100
From: Matthias Brugger <matthias.bgg@...il.com>
To: Alexandre Mergnat <amergnat@...libre.com>,
Flora Fu <flora.fu@...iatek.com>,
Dmitry Torokhov <dmitry.torokhov@...il.com>,
Tianping Fang <tianping.fang@...iatek.com>,
Fabien Parent <fabien.parent@...aro.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Liam Girdwood <lgirdwood@...il.com>,
Alexandre Belloni <alexandre.belloni@...tlin.com>,
Mark Brown <broonie@...nel.org>,
Sean Wang <sean.wang@...iatek.com>,
Chen Zhong <chen.zhong@...iatek.com>,
Pavel Machek <pavel@....cz>, Lee Jones <lee@...nel.org>,
Alessandro Zummo <a.zummo@...ertech.it>,
Rob Herring <robh+dt@...nel.org>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
Rob Herring <robh@...nel.org>,
Mattijs Korpershoek <mkorpershoek@...libre.com>,
linux-mediatek@...ts.infradead.org, linux-kernel@...r.kernel.org,
devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-leds@...r.kernel.org, Fabien Parent <fparent@...libre.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@...labora.com>,
linux-rtc@...r.kernel.org, linux-input@...r.kernel.org
Subject: Re: [PATCH v5 07/10] arm64: dts: mt6358: change node names
On 16/11/2022 13:33, Alexandre Mergnat wrote:
> - Change the node name from "mt6358" to "pmic" to be consistent
> with mediatek,pwrap.yaml documentation.
>
> - Change the node name from "mt6358rtc" to "rtc" to be consistent
> with mediatek,mt6397-rtc.yaml documentation.
>
> - Change the node name from "mt6358keys" to "keys" to be consistent
> with mediatek,pmic-keys.yaml documentation.
>
I think the node names should be changed anyway. So I'd advise to update the
commit message and I can take some right away.
Regards,
Matthias
> Signed-off-by: Alexandre Mergnat <amergnat@...libre.com>
> ---
> arch/arm64/boot/dts/mediatek/mt6358.dtsi | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt6358.dtsi b/arch/arm64/boot/dts/mediatek/mt6358.dtsi
> index 98f3b0e0c9f6..b605313bed99 100644
> --- a/arch/arm64/boot/dts/mediatek/mt6358.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt6358.dtsi
> @@ -5,7 +5,7 @@
> #include <dt-bindings/input/input.h>
>
> &pwrap {
> - pmic: mt6358 {
> + pmic: pmic {
> compatible = "mediatek,mt6358";
> interrupt-controller;
> interrupt-parent = <&pio>;
> @@ -355,11 +355,11 @@ mt6358_vsim2_reg: ldo_vsim2 {
> };
> };
>
> - mt6358rtc: mt6358rtc {
> + mt6358rtc: rtc {
> compatible = "mediatek,mt6358-rtc";
> };
>
> - mt6358keys: mt6358keys {
> + mt6358keys: keys {
> compatible = "mediatek,mt6358-keys";
> power {
> linux,keycodes = <KEY_POWER>;
>
Powered by blists - more mailing lists