linux-kernel - Re: [PATCH v2,1/3] media: dt-bindings: media: mediatek: vcodec: Fix clock num not correctly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 17 Nov 2022 02:16:49 +0000
From:   Yunfei Dong (董云飞) 
        <Yunfei.Dong@...iatek.com>
To:     "robh@...nel.org" <robh@...nel.org>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-mediatek@...ts.infradead.org" 
        <linux-mediatek@...ts.infradead.org>,
        Tiffany Lin (林慧珊) 
        <tiffany.lin@...iatek.com>,
        "wenst@...omium.org" <wenst@...omium.org>,
        "linux-media@...r.kernel.org" <linux-media@...r.kernel.org>,
        "stevecho@...omium.org" <stevecho@...omium.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "mchehab@...nel.org" <mchehab@...nel.org>,
        "daniel@...ll.ch" <daniel@...ll.ch>,
        Project_Global_Chrome_Upstream_Group 
        <Project_Global_Chrome_Upstream_Group@...iatek.com>,
        "hsinyi@...omium.org" <hsinyi@...omium.org>,
        "benjamin.gaignard@...labora.com" <benjamin.gaignard@...labora.com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "hverkuil-cisco@...all.nl" <hverkuil-cisco@...all.nl>,
        "matthias.bgg@...il.com" <matthias.bgg@...il.com>,
        "angelogioacchino.delregno@...labora.com" 
        <angelogioacchino.delregno@...labora.com>
Subject: Re: [PATCH v2,1/3] media: dt-bindings: media: mediatek: vcodec: Fix
 clock num not correctly

Hi Rob,

Thanks for your comments.
On Wed, 2022-11-16 at 11:29 -0600, Rob Herring wrote:
> On Thu, Nov 10, 2022 at 06:28:32PM +0800, Yunfei Dong wrote:
> > mt8195 and mt8192 have different clock numbers, can't write
> > 'clocks' and
> > 'clock-names' with const value.
> 
> Not a compatible change. Explain why that is okay if it is.
> 
This change is used for mt8195 platform for some architecture changed.
Need to separate vcodec-lat with vcodec-lat-soc into different child
node.

At the same time, vcodec-lat-soc don't have interrupt, but having power
domain and clks.
> > 
> > Move 'assigned-clocks' and 'assigned-clock-parents' to parent node.
> > 
> > Signed-off-by: Yunfei Dong <yunfei.dong@...iatek.com>
> > ---
> >  .../media/mediatek,vcodec-subdev-decoder.yaml | 119 +++++++++++---
> > ----
> >  1 file changed, 72 insertions(+), 47 deletions(-)
> > 
> > diff --git
> > a/Documentation/devicetree/bindings/media/mediatek,vcodec-subdev-
> > decoder.yaml
> > b/Documentation/devicetree/bindings/media/mediatek,vcodec-subdev-
> > decoder.yaml
> > index c4f20acdc1f8..794012853834 100644
> > --- a/Documentation/devicetree/bindings/media/mediatek,vcodec-
> > subdev-decoder.yaml
> > +++ b/Documentation/devicetree/bindings/media/mediatek,vcodec-
> > subdev-decoder.yaml
> > @@ -89,23 +89,33 @@ properties:
> >  
> >    ranges: true
> >  
> > +  clocks:
> > +    minItems: 1
> > +    maxItems: 5
> > +
> > +  clock-names:
> > +    minItems: 1
> > +    maxItems: 5
> 
> Why do both the parent and child have clocks?
> 
If move assigned-clock-parents to child node, need to add 'ssigned-
clock-parents' and 'assigned-clocks' for each child node. Only need to
add one in parent node, child node no need to add if add 'ssigned-
clock-parents' and 'assigned-clocks' in parent node.

Adding 'assigned-clock-parents' and 'assigned-clocks' need to add
'clocks' and 'clock-names', or will check fail.
> > +
> > +  assigned-clocks:
> > +    maxItems: 1
> > +
> > +  assigned-clock-parents:
> > +    maxItems: 1
> 
> You can just drop assigned-clock properties. They are allowed in any 
> node with 'clocks'.
> 
Only need to add one in parent node, or need to add for each child
node.
> > +
> >  # Required child node:
> >  patternProperties:
> > -  '^vcodec-lat@[0-9a-f]+$':
> > +  '^vcodec-lat-soc@[0-9a-f]+$':
> >      type: object
> >  
> >      properties:
> >        compatible:
> >          enum:
> > -          - mediatek,mtk-vcodec-lat
> >            - mediatek,mtk-vcodec-lat-soc
> >  
> >        reg:
> >          maxItems: 1
> >  
> > -      interrupts:
> > -        maxItems: 1
> > -
> 
> Dropping interrupts? Not explained in the commit msg (why?).
> 
vcodec-lat-soc no need interrupts, will add detail commit message in
next patch.
> >        iommus:
> >          minItems: 1
> >          maxItems: 32
> > @@ -114,22 +124,55 @@ patternProperties:
> >            Refer to bindings/iommu/mediatek,iommu.yaml.
> >  
> >        clocks:
> > +        minItems: 1
> >          maxItems: 5
> >  
> >        clock-names:
> > -        items:
> > -          - const: sel
> > -          - const: soc-vdec
> > -          - const: soc-lat
> > -          - const: vdec
> > -          - const: top
> > +        minItems: 1
> > +        maxItems: 5
> 
> We had names defined and now we don't. That's a step backwards.
> 
Mt8195/mt8192/mt8186/mt8188 have different clock number and clock
names, so change it like this, do you have any other suggestion?
> >  
> > -      assigned-clocks:
> > +      power-domains:
> 
> Adding power-domains?
Vcodec-lat-soc need power domain and add one new child node vcodec-lat-
soc.

Best Regards,
Yunfei Dong
> 
> Rob