linux-kernel - Re: [PATCH v2 4/4] gpio: i8255: Migrate to regmap API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bbe25d96e892e8cfd3f0da5d6755be22@walle.cc>
Date:   Thu, 17 Nov 2022 17:30:29 +0100
From:   Michael Walle <michael@...le.cc>
To:     Mark Brown <broonie@...nel.org>
Cc:     William Breathitt Gray <william.gray@...aro.org>,
        linus.walleij@...aro.org, brgl@...ev.pl,
        andriy.shevchenko@...ux.intel.com, linux-gpio@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 4/4] gpio: i8255: Migrate to regmap API

Am 2022-11-17 17:21, schrieb Mark Brown:
> On Thu, Nov 17, 2022 at 05:18:55PM +0100, Michael Walle wrote:
>> Am 2022-11-11 02:55, schrieb William Breathitt Gray:
> 
>> > +	gpio_config.parent = config->parent;
>> > +	gpio_config.regmap = config->map;
> 
>> I'd propose to add a new config flag to indicate that accesses to
>> the device will be fast:
> 
>> gpio_config.regmap_has_fast_io = true;
> 
>> which will then set gpio->can_sleep = false.
> 
> It's probably useful to provide a query function in the regmap
> API for generic regmap users like this.

Now I'm confused. Last time, I've proposed that, there was push
back from you:
https://lore.kernel.org/linux-gpio/20210430151908.GC5981@sirena.org.uk/

That being said, I'd prefer to have such a query API :)

-michael