linux-kernel - Re: [PATCH] dt-bindings: iio: adc: qcom,spmi-vadc: fix PM8350 define

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20221117165806.00007f55@huawei.com>
Date:   Thu, 17 Nov 2022 16:58:06 +0000
From:   Jonathan Cameron <Jonathan.Cameron@...wei.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
CC:     Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>,
        "Bjorn Andersson" <andersson@...nel.org>,
        Jonathan Cameron <jic23@...nel.org>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Andy Gross <agross@...nel.org>, <linux-iio@...r.kernel.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] dt-bindings: iio: adc: qcom,spmi-vadc: fix PM8350
 define

On Thu, 17 Nov 2022 17:21:25 +0100
Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org> wrote:

> On 17/11/2022 16:56, Jonathan Cameron wrote:
> > On Thu, 17 Nov 2022 13:28:33 +0100
> > Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org> wrote:
> >   
> >> On 17/11/2022 13:22, Manivannan Sadhasivam wrote:  
> >>> On Thu, Nov 17, 2022 at 01:13:07PM +0100, Krzysztof Kozlowski wrote:    
> >>>> The defines from include/dt-bindings/iio/qcom,spmi-adc7-pm8350.h were
> >>>> changed to take sid argument:
> >>>>
> >>>>   Error: Documentation/devicetree/bindings/iio/adc/qcom,spmi-vadc.example.dts:99.28-29 syntax error
> >>>>
> >>>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>    
> >>>
> >>> Looks like I didn't rebase on top of Bjorn's for-next for my series, so didn't
> >>> see this example.
> >>>
> >>> Thanks for fixing!
> >>>
> >>> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
> >>>     
> >>
> >> This should not go via Bjorn's tree without IIO ack and
> >> Jonathan/Lars-Peter/IIO lists were not in CC.
> >>  
> > Thanks for the heads up. 
> > 
> > Not sure I'd have registered there would have been a problem here even
> > if I had seen original patch.  Anyhow, I assume Bjorn will pick this up
> > and all will be well again.
> > 
> > Acked-by: Jonathan Cameron <Jonathan.Cameron@...wei.com>  
> 
> I am afraid it cannot go via Bjorn's tree, because this depends on a
> change in your tree:
> https://lore.kernel.org/all/20221027143411.277980-2-krzysztof.kozlowski@linaro.org/
> 
> Can you pick it up instead? This is the only way to fix the linux-next,
> although your tree will have a dt_binding_check error.
> 
> Other way is to have cross-tree merge, but the commit to bindings
> headers ended up in DTS patch, so it cannot be shared with driver tree.

Ah. I've sent Greg a pull reuqest including that patch, so this is going to get
worse and the linux-next intermediate builds are going to fail which is never good.

Best bet at this point may be for Bjorn to also take the dependency 
you list above and the fix.

Git will happily unwind the same patch turning up in two trees and
that way he'll have everything and the IIO tree  + char-misc will
be fine on their own as well.

That work for everyone?

Jonathan



> 
> Best regards,
> Krzysztof
>