[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ec1bd4b0-6ef1-1673-edaa-8d2abc3e6957@embeddedor.com>
Date: Wed, 16 Nov 2022 19:06:16 -0600
From: "Gustavo A. R. Silva" <gustavo@...eddedor.com>
To: Kees Cook <keescook@...omium.org>,
"Gustavo A. R. Silva" <gustavoars@...nel.org>
Cc: Hante Meuleman <hante.meuleman@...adcom.com>,
Franky Lin <franky.lin@...adcom.com>,
Arend van Spriel <aspriel@...il.com>,
Kalle Valo <kvalo@...nel.org>,
"David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>,
Paolo Abeni <pabeni@...hat.com>,
SHA-cyfmac-dev-list@...ineon.com,
brcm80211-dev-list.pdl@...adcom.com, netdev@...r.kernel.org,
linux-wireless@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-hardening@...r.kernel.org
Subject: Re: [PATCH 2/2][next] wifi: brcmfmac: Use struct_size() in code
ralated to struct brcmf_dload_data_le
On 11/16/22 16:23, Kees Cook wrote:
> On Tue, Nov 15, 2022 at 03:55:34PM -0600, Gustavo A. R. Silva wrote:
>> Prefer struct_size() over open-coded versions of idiom:
>>
>> sizeof(struct-with-flex-array) + sizeof(typeof-flex-array-elements) * count
>>
>> where count is the max number of items the flexible array is supposed to
>> contain.
>>
>> In this particular case, in the open-coded version sizeof(typeof-flex-array-elements)
>> is implicit in _count_ because the type of the flex array data is u8:
>>
>> drivers/net/wireless/broadcom/brcm80211/brcmfmac/fwil_types.h:941:
>> 941 struct brcmf_dload_data_le {
>> 942 __le16 flag;
>> 943 __le16 dload_type;
>> 944 __le32 len;
>> 945 __le32 crc;
>> 946 u8 data[];
>> 947 };
>>
>> Link: https://github.com/KSPP/linux/issues/160
>> Signed-off-by: Gustavo A. R. Silva <gustavoars@...nel.org>
>
> Reviewed-by: Kees Cook <keescook@...omium.org>
>
Thanks for the reviews! :)
--
Gustavo
Powered by blists - more mailing lists