linux-kernel - Re: [PATCH] PCI: dwc: add missing free_irq() in ks_pcie_remove() and error path in ks_pcie

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202211180208.PTqz0RnA-lkp@intel.com>
Date:   Fri, 18 Nov 2022 02:28:16 +0800
From:   kernel test robot <lkp@...el.com>
To:     ruanjinjie <ruanjinjie@...wei.com>, lpieralisi@...nel.org,
        robh@...nel.org, kw@...ux.com, bhelgaas@...gle.com,
        Sergey.Semin@...kalelectronics.ru, mani@...nel.org, kishon@...com,
        naveennaidu479@...il.com, pali@...nel.org, ffclaire1224@...il.com,
        linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:     llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
        ruanjinjie@...wei.com
Subject: Re: [PATCH] PCI: dwc: add missing free_irq() in ks_pcie_remove() and
 error path in ks_pcie_probe()

Hi ruanjinjie,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on helgaas-pci/next]
[also build test ERROR on helgaas-pci/for-linus linus/master v6.1-rc5 next-20221117]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/ruanjinjie/PCI-dwc-add-missing-free_irq-in-ks_pcie_remove-and-error-path-in-ks_pcie_probe/20221116-102615
base:   https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git next
patch link:    https://lore.kernel.org/r/20221116022147.2636355-1-ruanjinjie%40huawei.com
patch subject: [PATCH] PCI: dwc: add missing free_irq() in ks_pcie_remove() and error path in ks_pcie_probe()
config: arm-randconfig-c002-20221116
compiler: clang version 16.0.0 (https://github.com/llvm/llvm-project 463da45892e2d2a262277b91b96f5f8c05dc25d0)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install arm cross compiling tool for clang build
        # apt-get install binutils-arm-linux-gnueabi
        # https://github.com/intel-lab-lkp/linux/commit/7e5242b1d6838ee186e17b970fd3516cbe2e41a8
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review ruanjinjie/PCI-dwc-add-missing-free_irq-in-ks_pcie_remove-and-error-path-in-ks_pcie_probe/20221116-102615
        git checkout 7e5242b1d6838ee186e17b970fd3516cbe2e41a8
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm SHELL=/bin/bash drivers/pci/controller/dwc/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

>> drivers/pci/controller/dwc/pci-keystone.c:1324:11: error: use of undeclared identifier 'irq'
           free_irq(irq, ks_pcie);
                    ^
   1 error generated.


vim +/irq +1324 drivers/pci/controller/dwc/pci-keystone.c

  1311	
  1312	static int __exit ks_pcie_remove(struct platform_device *pdev)
  1313	{
  1314		struct keystone_pcie *ks_pcie = platform_get_drvdata(pdev);
  1315		struct device_link **link = ks_pcie->link;
  1316		int num_lanes = ks_pcie->num_lanes;
  1317		struct device *dev = &pdev->dev;
  1318	
  1319		pm_runtime_put(dev);
  1320		pm_runtime_disable(dev);
  1321		ks_pcie_disable_phy(ks_pcie);
  1322		while (num_lanes--)
  1323			device_link_del(link[num_lanes]);
> 1324		free_irq(irq, ks_pcie);
  1325	
  1326		return 0;
  1327	}
  1328	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (181749 bytes)