linux-kernel - Re: [PATCH] staging: vt6655: change the function name s

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <52392ad9-545f-c5b3-9ad4-2bf539cf0031@gmail.com>
Date:   Thu, 17 Nov 2022 20:33:36 +0100
From:   Philipp Hortmann <philipp.g.hortmann@...il.com>
To:     Tanjuate Brunostar <tanjubrunostar0@...il.com>,
        gregkh@...uxfoundation.org
Cc:     linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org,
        outreachy@...ts.linux.dev
Subject: Re: [PATCH] staging: vt6655: change the function name s_vFillCTSHead

On 11/15/22 13:40, Tanjuate Brunostar wrote:
> Remove the use of Hungarian notation, which is not used in the Linux
> kernel. Reported by checkpatch
> Add indentation to the affected function to follow the Linux kernel
> coding style. This improves visibility
> 
> Signed-off-by: Tanjuate Brunostar <tanjubrunostar0@...il.com>
> ---
>   drivers/staging/vt6655/rxtx.c | 26 +++++++++++---------------
>   1 file changed, 11 insertions(+), 15 deletions(-)
> 
> diff --git a/drivers/staging/vt6655/rxtx.c b/drivers/staging/vt6655/rxtx.c
> index 341e23054817..869685d27abe 100644
> --- a/drivers/staging/vt6655/rxtx.c
> +++ b/drivers/staging/vt6655/rxtx.c
> @@ -21,7 +21,7 @@
>    *      s_uGetRTSCTSDuration- get rtx/cts required duration
>    *      get_rtscts_time- get rts/cts reserved time
>    *      s_uGetTxRsvTime- get frame reserved time
> - *      s_vFillCTSHead- fulfill CTS ctl header
> + *      fill_cts_header- fulfill CTS ctl header
>    *      s_vFillFragParameter- Set fragment ctl parameter.
>    *      fill_rts_header- fulfill RTS ctl header
>    *      s_vFillTxKey- fulfill tx encrypt key
> @@ -724,19 +724,15 @@ static void fill_rts_header(struct vnt_private *pDevice,
>   	}
>   }
>   
> -static
> -void
> -s_vFillCTSHead(
> -	struct vnt_private *pDevice,
> -	unsigned int uDMAIdx,
> -	unsigned char byPktType,
> -	void *pvCTS,
> -	unsigned int cbFrameLength,
> -	bool bNeedAck,
> -	bool bDisCRC,
> -	unsigned short wCurrentRate,
> -	unsigned char byFBOption
> -)
> +static void fill_cts_header(struct vnt_private *pDevice,
> +			    unsigned int uDMAIdx,
> +			    unsigned char byPktType,
> +			    void *pvCTS,
> +			    unsigned int cbFrameLength,
> +			    bool bNeedAck,
> +			    bool bDisCRC,
> +			    unsigned short wCurrentRate,
> +			    unsigned char byFBOption)
>   {
>   	unsigned int uCTSFrameLen = 14;
>   
> @@ -891,7 +887,7 @@ static void generate_tx_parameter(struct vnt_private *pDevice,
>   			buf->cts_rrv_time_ba = get_rtscts_time(pDevice, 3, byPktType, cbFrameSize, wCurrentRate);
>   
>   			/* Fill CTS */
> -			s_vFillCTSHead(pDevice, uDMAIdx, byPktType, pvCTS, cbFrameSize, bNeedACK, bDisCRC, wCurrentRate, byFBOption);
> +			fill_cts_header(pDevice, uDMAIdx, byPktType, pvCTS, cbFrameSize, bNeedACK, bDisCRC, wCurrentRate, byFBOption);
>   		}
>   	} else if (byPktType == PK_TYPE_11A) {
>   		if (pvRTS) {/* RTS_need, non PCF mode */

Hi,

cannot apply your patch.

kernel@...rix-ESPRIMO-P710:~/Documents/git/kernels/staging$ git apply 
--reject --ignore-space-change --ignore-whitespace 
~/Downloads/20221115-\[PATCH\]\ staging_\ vt6655_\ change\ the\ 
function\ name\ s_vFillCTSHead-5410.txt
Checking patch drivers/staging/vt6655/rxtx.c...
error: while searching for:
  *      s_uGetRTSCTSDuration- get rtx/cts required duration
  *      get_rtscts_time- get rts/cts reserved time
  *      s_uGetTxRsvTime- get frame reserved time
  *      s_vFillCTSHead- fulfill CTS ctl header
  *      s_vFillFragParameter- Set fragment ctl parameter.
  *      fill_rts_header- fulfill RTS ctl header
  *      s_vFillTxKey- fulfill tx encrypt key

error: patch failed: drivers/staging/vt6655/rxtx.c:21
Hunk #2 succeeded at 762 (offset 38 lines).
Hunk #3 succeeded at 929 (offset 42 lines).
Applying patch drivers/staging/vt6655/rxtx.c with 1 reject...
Rejected hunk #1.
Hunk #2 applied cleanly.
Hunk #3 applied cleanly.

Please post the output of the following commands:
git remote show origin
git branch -a

Thanks for your support.

Bye Philipp