linux-kernel - Re: [PATCH linux-next] selftests/vm: calculate variables in correct order

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y3aojfUC2nSwbCzB@x1n>
Date:   Thu, 17 Nov 2022 16:33:01 -0500
From:   Peter Xu <peterx@...hat.com>
To:     Joel Savitz <jsavitz@...hat.com>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        linux-kernel@...r.kernel.org, Shuah Khan <shuah@...nel.org>,
        David Hildenbrand <dhildenb@...hat.com>,
        Nico Pache <npache@...hat.com>, linux-mm@...ck.org,
        linux-kselftest@...r.kernel.org
Subject: Re: [PATCH linux-next] selftests/vm: calculate variables in correct
 order

On Wed, Nov 16, 2022 at 08:09:11PM -0400, Joel Savitz wrote:
> However, I noticed that on the mm-everything branch, the hugepage-mmap test
> fails:
> 
> # ./run_vmtests.sh -t "hugetlb"
> running: ./hugepage-mmap
> -----------------------
> running ./hugepage-mmap
> -----------------------
> Open failed: No such file or directory
> [FAIL]
> ...
> 
> It appears this is due to commit 0796c7b8be84 ("selftests/vm: drop mnt
> point for hugetlb in run_vmtests.sh")
> as the test still replies on the ./huge mountpoint removed in that commit.
> The test passes before that patchset is applied.

Oops, sorry I totally overlooked this hard-coded test case using the
mntpoint.

Fix is simple though, which is attached.

-- 
Peter Xu

View attachment "0001-selftests-vm-use-memfd-for-hugepage-mmap-test.patch" of type "text/plain" (1757 bytes)