[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <84550d9e-c3c5-e3b8-133a-9b64e1e31918@linaro.org>
Date: Thu, 17 Nov 2022 09:09:49 +0100
From: Neil Armstrong <neil.armstrong@...aro.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
Konrad Dybcio <konrad.dybcio@...ainline.org>,
Georgi Djakov <djakov@...nel.org>,
Andy Gross <agross@...nel.org>,
Bjorn Andersson <andersson@...nel.org>,
Rob Herring <robh+dt@...nel.org>
Cc: devicetree@...r.kernel.org, linux-pm@...r.kernel.org,
linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: interconnect: qcom-bwmon: document SM8550
compatibles
On 16/11/2022 11:31, Krzysztof Kozlowski wrote:
> On 16/11/2022 11:14, Neil Armstrong wrote:
>> This documents the compatibles used to describe the Bandwidth Monitors
>> present on the SM8550 platform.
>
> Do not use "This commit/patch", so just "Document the ...."
>
> https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95
>
>>
>> A BWMON v4 IP monitors the CPU bandwidth, and a v5 does the LLCC
>> bandwidth monitoring.
>>
>> This is described this by adding "llcc" and "cpu" into the compatible
>
> One "this" too many.
>
>> strings to differentiate the BWMON IPs.
>>
>
>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Thanks, will fix the commit message accordingly.
Neil
>
> Best regards,
> Krzysztof
>
Powered by blists - more mailing lists