linux-kernel - Re: [PATCH v2 2/2] PCI: Allow building CONFIG_OF drivers with COMPILE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 17 Nov 2022 09:55:08 +0100
From:   Geert Uytterhoeven <geert@...ux-m68k.org>
To:     Bjorn Helgaas <helgaas@...nel.org>
Cc:     linux-pci@...r.kernel.org,
        Lorenzo Pieralisi <lpieralisi@...nel.org>,
        Pali Rohár <pali@...nel.org>,
        Rob Herring <robh@...nel.org>,
        Krzysztof Wilczyński <kw@...ux.com>,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        Bjorn Helgaas <bhelgaas@...gle.com>
Subject: Re: [PATCH v2 2/2] PCI: Allow building CONFIG_OF drivers with COMPILE_TEST

Hi Bjorn,

On Wed, Nov 16, 2022 at 9:51 PM Bjorn Helgaas <helgaas@...nel.org> wrote:
> From: Bjorn Helgaas <bhelgaas@...gle.com>
>
> Many drivers depend on OF interfaces, so they won't be functional if
> CONFIG_OF is not set.  But OF provides stub functions in that case, so make
> them buildable if CONFIG_COMPILE_TEST is set.
>
> Signed-off-by: Bjorn Helgaas <bhelgaas@...gle.com>

Thanks for the update!

> --- a/drivers/pci/controller/cadence/Kconfig
> +++ b/drivers/pci/controller/cadence/Kconfig

> @@ -158,8 +162,9 @@ config PCI_LAYERSCAPE_EP
>           controller works in RC mode.
>
>  config PCI_HISI
> -       depends on OF && (ARM64 || COMPILE_TEST)
>         bool "HiSilicon Hip05 and Hip06 SoCs PCIe controllers"
> +       depends on ARM64 || COMPILE_TEST
> +       depends on OF || COMPILE_TEST

Note that ARM64 selects OF, so this (and a few others) could be
simplified by dropping the "depends on OF || COMPILE_TEST".
But that might be the scope of a different patch?

>         depends on PCI_MSI_IRQ_DOMAIN
>         select PCIE_DW_HOST
>         select PCI_HOST_COMMON

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds