linux-kernel - Re: linux-next: build failure after merge of the ntfs3 tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20221117085644.52r6gviioifzysqn@wittgenstein>
Date:   Thu, 17 Nov 2022 09:56:44 +0100
From:   Christian Brauner <brauner@...nel.org>
To:     Stephen Rothwell <sfr@...b.auug.org.au>
Cc:     Konstantin Komarov <almaz.alexandrovich@...agon-software.com>,
        Christian Brauner <christian@...uner.io>,
        Seth Forshee <sforshee@...nel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux Next Mailing List <linux-next@...r.kernel.org>
Subject: Re: linux-next: build failure after merge of the ntfs3 tree

On Tue, Nov 15, 2022 at 10:17:56AM +1100, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the ntfs3 tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> fs/ntfs3/namei.c: In function 'ntfs_atomic_open':
> fs/ntfs3/namei.c:374:39: error: implicit declaration of function 'get_acl' [-Werror=implicit-function-declaration]
>   374 |                 struct posix_acl *p = get_acl(dir, ACL_TYPE_DEFAULT);
>       |                                       ^~~~~~~
> fs/ntfs3/namei.c:374:39: error: initialization of 'struct posix_acl *' from 'int' makes pointer from integer without a cast [-Werror=int-conversion]
> 
> Caused by commit
> 
>   2b108260ea2c ("fs/ntfs3: atomic_open implementation")
> 
> interacting with commit
> 
>   cac2f8b8d8b5 ("fs: rename current get acl method")
> 
> I have applied the following merge fix patch for today.
> 
> From: Stephen Rothwell <sfr@...b.auug.org.au>
> Date: Tue, 15 Nov 2022 10:07:59 +1100
> Subject: [PATCH] fix up for "fs: rename current get acl method"
> 
> Signed-off-by: Stephen Rothwell <sfr@...b.auug.org.au>
> ---
>  fs/ntfs3/namei.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/ntfs3/namei.c b/fs/ntfs3/namei.c
> index 20a6ac883312..c8db35e2ae17 100644
> --- a/fs/ntfs3/namei.c
> +++ b/fs/ntfs3/namei.c
> @@ -371,7 +371,7 @@ static int ntfs_atomic_open(struct inode *dir, struct dentry *dentry,
>  		 * ntfs_create_inode -> ntfs_init_acl -> posix_acl_create ->
>  		 * ntfs_get_acl -> ntfs_get_acl_ex -> ni_lock
>  		 */
> -		struct posix_acl *p = get_acl(dir, ACL_TYPE_DEFAULT);
> +		struct posix_acl *p = get_inode_acl(dir, ACL_TYPE_DEFAULT);
>  
>  		if (IS_ERR(p)) {
>  			err = PTR_ERR(p);

Hey Stephen,

Thank you for the report! Your fix is correct. @Konstantin can either
pull in

ssh://git@...olite.kernel.org/pub/scm/linux/kernel/git/vfs/idmapping.git fs.acl.rework

or I'll make a note and will let Linus know during the merge window
about this issue. In the latter case I'd just copy-paste your patch to
Linus, Stephen?

Thanks!
Christian