linux-kernel - Re: [PATCH v4 3/7] pwm: lpss: Include headers we are the direct user of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y3X47vdt8MpHNzcB@smile.fi.intel.com>
Date:   Thu, 17 Nov 2022 11:03:42 +0200
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>
Cc:     Mika Westerberg <mika.westerberg@...ux.intel.com>,
        Thierry Reding <thierry.reding@...il.com>,
        Hans de Goede <hdegoede@...hat.com>,
        linux-kernel@...r.kernel.org, linux-gpio@...r.kernel.org,
        linux-pwm@...r.kernel.org, Linus Walleij <linus.walleij@...aro.org>
Subject: Re: [PATCH v4 3/7] pwm: lpss: Include headers we are the direct user
 of

On Thu, Nov 17, 2022 at 09:50:27AM +0100, Uwe Kleine-König wrote:
> On Mon, Nov 14, 2022 at 06:55:41PM +0200, Andy Shevchenko wrote:
> > For the sake of integrity, include headers we are the direct
> > user of.
> > 
> > Replace the inclusion of device.h by a forward declaration
> > of struct device plus a (cheaper) of types.h as device.h is
> > an expensive include (measured in compiler effort).
> > 
> > While at it, move the struct pwm_lpss_chip to be after
> > the struct pwm_lpss_boardinfo as the former uses pointer
> > to the latter.
> 
> I stand by my feedback that this change is irrelevant in the end. If you
> drop it here, the patch gets a bit nicer.

OK, since you are insisting, I will modify this in v5.

-- 
With Best Regards,
Andy Shevchenko