linux-kernel - Re: [PATCH 1/4] media: i2c: s5k6a3: switch to using gpiod API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 17 Nov 2022 10:04:50 +0100
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc:     Mauro Carvalho Chehab <mchehab@...nel.org>,
        Sylwester Nawrocki <s.nawrocki@...sung.com>,
        Andrzej Hajda <andrzej.hajda@...el.com>,
        linux-kernel@...r.kernel.org, linux-media@...r.kernel.org
Subject: Re: [PATCH 1/4] media: i2c: s5k6a3: switch to using gpiod API

On Tue, Nov 15, 2022 at 11:11 PM Dmitry Torokhov
<dmitry.torokhov@...il.com> wrote:

> This patch switches the driver away from legacy gpio/of_gpio API to
> gpiod API, and removes one of the last uses of of_get_gpio_flags().
>
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@...il.com>

Reviewed-by: Linus Walleij <linus.walleij@...aro.org>

> -       sensor->gpio_reset = -EINVAL;
> -       sensor->clock = ERR_PTR(-EINVAL);

Looks unrelated but makes sense.

>         sensor->dev = dev;
>
>         sensor->clock = devm_clk_get(sensor->dev, S5K6A3_CLK_NAME);

Given that it is initialized unconditionally two lines down :P

Yours,
Linus Walleij