linux-kernel - Re: [PATCH v2] dmaengine: ste_dma40: use devm_request_irq to avoid missing free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdZCwDvJkOr+7_3ua_sb1p70pMDcx7UTcH=VTKQBvX9iLA@mail.gmail.com>
Date:   Thu, 17 Nov 2022 10:07:21 +0100
From:   Linus Walleij <linus.walleij@...aro.org>
To:     ruanjinjie <ruanjinjie@...wei.com>
Cc:     vkoul@...nel.org, linux-arm-kernel@...ts.infradead.org,
        dmaengine@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] dmaengine: ste_dma40: use devm_request_irq to avoid
 missing free_irq() in error path

On Wed, Nov 16, 2022 at 8:01 AM ruanjinjie <ruanjinjie@...wei.com> wrote:

> free_irq() is missing in some cases of error in d40_probe(), use
> devm_request_irq to fix that.
>
> Fixes: d7b7ecce4bcb ("ste_dma40: Rename a jump label in d40_probe()")
> Signed-off-by: ruanjinjie <ruanjinjie@...wei.com>
> ---
> v2:
> - use devm_request_irq instead of adding free_irq() to fix the problem.

Thanks!
Reviewed-by: Linus Walleij <linus.walleij@...aro.org>

Yours,
Linus Walleij