linux-kernel - Re: [PATCH] perf: arm_cspmu: Fix module cyclic dependency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1c86647f-a479-cfa9-3ac6-d5001f7843b7@arm.com>
Date:   Thu, 17 Nov 2022 09:19:16 +0000
From:   Suzuki K Poulose <suzuki.poulose@....com>
To:     Besar Wicaksono <bwicaksono@...dia.com>, catalin.marinas@....com,
        will@...nel.org, mark.rutland@....com
Cc:     linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        linux-tegra@...r.kernel.org, treding@...dia.com,
        jonathanh@...dia.com, vsethi@...dia.com, ywan@...dia.com
Subject: Re: [PATCH] perf: arm_cspmu: Fix module cyclic dependency

On 16/11/2022 20:39, Besar Wicaksono wrote:
> Build on arm64 allmodconfig failed with:
>    | depmod: ERROR: Cycle detected: arm_cspmu -> nvidia_cspmu -> arm_cspmu
>    | depmod: ERROR: Found 2 modules in dependency cycles!
> 
> The arm_cspmu.c provides standard functions to operate the PMU and the
> vendor code provides vendor specific attributes. Both need to be built as
> single kernel module.
> 
> Update the makefile to compile sources under arm_cspmu into one module.
> 
> Signed-off-by: Besar Wicaksono <bwicaksono@...dia.com>
> ---
>   drivers/perf/arm_cspmu/Makefile | 5 ++---
>   1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/perf/arm_cspmu/Makefile b/drivers/perf/arm_cspmu/Makefile
> index 641db85c018b..fedb17df982d 100644
> --- a/drivers/perf/arm_cspmu/Makefile
> +++ b/drivers/perf/arm_cspmu/Makefile
> @@ -2,6 +2,5 @@
>   #
>   # SPDX-License-Identifier: GPL-2.0
>   
> -obj-$(CONFIG_ARM_CORESIGHT_PMU_ARCH_SYSTEM_PMU) += \
> -	arm_cspmu.o \
> -	nvidia_cspmu.o
> +obj-$(CONFIG_ARM_CORESIGHT_PMU_ARCH_SYSTEM_PMU) += arm_cspmu_module.o
> +arm_cspmu_module-y := arm_cspmu.o nvidia_cspmu.o
> 

Reviewed-and-Tested-by: Suzuki K Poulose <suzuki.poulose@....com>

> base-commit: 9500fc6e9e6077616c0dea0f7eb33138be94ed0c