linux-kernel - Re: [PATCH wireless] wilc1000: fix potential memory leak in wilc_mac

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <877cztsxhw.fsf@kernel.org>
Date:   Thu, 17 Nov 2022 12:09:47 +0200
From:   Kalle Valo <kvalo@...nel.org>
To:     Zhang Changzhong <zhangchangzhong@...wei.com>
Cc:     Ajay Singh <ajay.kathat@...rochip.com>,
        Claudiu Beznea <claudiu.beznea@...rochip.com>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        "Jakub Kicinski" <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Johnny Kim <johnny.kim@...el.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Chris Park <chris.park@...el.com>,
        Rachel Kim <rachel.kim@...el.com>,
        "Nicolas Ferre" <nicolas.ferre@...rochip.com>,
        <linux-wireless@...r.kernel.org>, <netdev@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH wireless] wilc1000: fix potential memory leak in wilc_mac_xmit()

Zhang Changzhong <zhangchangzhong@...wei.com> writes:

> The wilc_mac_xmit() returns NETDEV_TX_OK without freeing skb, add
> dev_kfree_skb() to fix it.
>
> Fixes: c5c77ba18ea6 ("staging: wilc1000: Add SDIO/SPI 802.11 driver")
> Signed-off-by: Zhang Changzhong <zhangchangzhong@...wei.com>

Same as in your other patch, have you tested this is on a real device?

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches