linux-kernel - Re: [PATCH] perf: Fix sys_perf_event

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 17 Nov 2022 16:29:31 +0530
From:   Ravi Bangoria <ravi.bangoria@....com>
To:     Borislav Petkov <bp@...en8.de>
Cc:     Peter Zijlstra <peterz@...radead.org>, nslusarek@....net,
        Linus Torvalds <torvalds@...ux-foundation.org>, x86@...nel.org,
        linux-kernel@...r.kernel.org, Ravi Bangoria <ravi.bangoria@....com>
Subject: Re: [PATCH] perf: Fix sys_perf_event_open() race against self

On 17-Nov-22 4:10 PM, Borislav Petkov wrote:
> On Thu, Nov 17, 2022 at 04:03:54PM +0530, Ravi Bangoria wrote:
>> The issue was because of multiple event contexts involved. However,
>> it's no longer the case with reworked event context.
> 
> I got that but it wouldn't hurt to have this test regardless, no?
> 
> More testing is pretty much always better...

I do agree that more tests are always better. Though, this simple program
was to test a _specific race condition_ which no longer exists in kernel.
So even if we add it, what would it test?

Thanks,
Ravi